Page MenuHomePhabricator

Don't break Cite VisualEditor integration
Closed, ResolvedPublic

Description

We've decided that the initial release of Book Referencing won't have any new VisualEditor logic to edit or render subreferences (TODO: team to confirm). However, we can't regress what VE integration Cite already has.

Acceptance criteria:

  • Define fallback rendering for subreferences in VE. E.g., they have sequential numbering and no indentation.
  • Define fallback editing behavior and edge cases for subreferences in VE.
  • Browser tests to guarantee that current VE integrations still work.
  • Browser tests for subref fallback behaviors in VE.

Event Timeline

We have our first bug report about this! https://www.mediawiki.org/wiki/Topic:Vcr5pdq2c45docll

After updating from version "20e26df" to the above mentioned version I noticed that it is not possible to paste text in the cite input box. After spending much time trying to update parsoid and visualeditor, I found out that downgrading Cite fixes the problem.

We've decided that the initial release of Book Referencing won't have any new VisualEditor logic to edit or render subreferences

This feels like something that needs to be discussed between Release Engineering and the Editing and WMDE teams; would @JStrodt_WMDE be the best person from WMDE for product/rollout decisions?

@Jdforrester-WMF we don't currently have a product manager—we expect a new hire to start in January. But in the meantime, perhaps our engineering manager @Tobi_WMDE_SW can coordinate this. It would be great to discuss, and collaboratively decide on the next steps. We've roadmapped that our team will implement Book Referencing over the next six months, but we can be flexible in the details, which features are deployed first, and so on.

thiemowmde claimed this task.
thiemowmde added a subscriber: thiemowmde.

We know VisualEditor doesn't break in any way, and does not cause any data loss. Making VisualEditor more compatible with Book-Referencing in so far that it is able to show and possible edit the parent reference is now tracked in other tickets.