Page MenuHomePhabricator

Write integration tests for XML dumps with multiple MCR slots per revision
Closed, ResolvedPublic

Description

The existing PHPUnit tests for the 0.11 schema do not cover dumps of revisions that contain slots beyond the main slot. This needs to be fixed before we start using the 0.11 schema in production.

Implementation note: this can probable be achieved best by rewriting the tests to check the output against fixture files, instead of validating the contents of the dump files programmatically.

Event Timeline

daniel created this task.
daniel updated the task description. (Show Details)

Change 554919 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WIP: Make dump tests based on fixture files.

https://gerrit.wikimedia.org/r/554919

daniel triaged this task as Medium priority.Dec 12 2019, 1:31 PM
daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.
Pchelolo subscribed.

The patch seems to fail in the gate pipeline and it seems for a valid reason, thus it needs more work

Change 554919 merged by jenkins-bot:
[mediawiki/core@master] Make dump tests based on fixture files.

https://gerrit.wikimedia.org/r/554919