Hide delete button from "Create new component" page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Dec 9 2019, 5:15 PM

Description

Problem

The delete button is displayed when watching a new component and will crash the site.

Proposed solution

Hide the delete button when an user is creating a component.

Student is expected to upload a patch against labs/tools/watch-translations repository at Wikimedia Gerrit. Student should claim Phabricator task while claiming task at the GCI site.

Materials

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Prevent deletion of nonexistent components	labs/tools/watch-translations	master	+48 -38

Customize query in gerrit

Related Objects

Mentioned In: T240650: Fix ongoing form validation issues
T240218: Fix various issues with the delete button

Event Timeline

Urbanecm created this task.Dec 9 2019, 5:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2019, 5:15 PM

Urbanecm mentioned this in T240218: Fix various issues with the delete button.Dec 9 2019, 5:16 PM

https://codein.withgoogle.com/tasks/4774161507942400/

Aklapper renamed this task from Hide delete button from "Create new compnent" page to Hide delete button from "Create new component" page.Dec 9 2019, 8:12 PM

• Vargas04 triaged this task as Unbreak Now! priority.Dec 10 2019, 3:02 PM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptDec 10 2019, 3:02 PM

Nirmos lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 10 2019, 8:21 PM

It makes the site unusable, even after clearing cookies cookies or using a new browser.

@BrandonXLF: Do you plan to work on fixing this task, as you increased the priority of this task?

@Aklapper Probably, it's just that I can't view the web interface because I get a 502 Bad Gateway error since I deleted a new component, on two different accounts.

BrandonXLF claimed this task.Dec 12 2019, 12:27 AM

Change 556518 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[labs/tools/watch-translations@master] Add template for creating new components

https://gerrit.wikimedia.org/r/556518

gerritbot added a project: Patch-For-Review.Dec 12 2019, 4:55 AM

Arcayn moved this task from Backlog to Working on on the WatchTranslations board.Dec 12 2019, 11:30 PM

Arcayn subscribed.Dec 13 2019, 12:11 AM

Arcayn mentioned this in T240650: Fix ongoing form validation issues.Dec 13 2019, 1:53 AM

Change 557272 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[labs/tools/watch-translations@master] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/labs/tools/watch-translations into T240237

https://gerrit.wikimedia.org/r/557272

Change 557272 abandoned by BrandonXLF:
Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/labs/tools/watch-translations into T240237

Reason:
Made by mistake