Page MenuHomePhabricator
Create Task
Maniphest T240258

Make WatchTranslations use identity-only email-allowed token
Open, Needs TriagePublic
Actions

Description

The tool currently uses a token that asks for (and only for) viewmyprivatedata. That doesn't display as an user friendly message, and might frighten some users.

Original description

When I tried to access WatchTranslations, I got a message saying that it would access my private data. The nature of the private data was not specified, and the reason for requesting access to private data was not specified. If WatchTranslations needs access to private data then I think that the nature of the data and the reasons for the request should be explained.

Related Objects
Search...

Event Timeline

Pine created this task.Dec 9 2019, 8:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2019, 8:08 PM
Aklapper changed the task status from Open to Stalled.EditedDec 9 2019, 8:41 PM

Hi @Pine, thanks for taking the time to report. If something displays some message somewhere, then please provide a clear and exact list of steps to reproduce which allow anyone else to reproduce the same problem, plus the exact message. Please see https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks!

Urbanecm subscribed.Dec 9 2019, 10:19 PM

@Pine Hello, thanks for filling this! "Access private data about you" decriphers to viewmyprivateinfo user right, which I felt is required for getting access to user email, which I need to send HTMLized emails. The tool requests the email when it wants to email the user, and immediatelly discards it. It does, however, store the OAuth tokens. You can terminate them at any time using your preferences at any Wikimedia wiki.

I'll make sure a message like this is included in the tool itself. Now that I look into the form for getting OAuth tokens, I see there is a dedicated checkbox to request identity+email information. I'll definitely look into that, so the interface is cleaner.

In T240258#5725607, @Aklapper wrote:

Hi @Pine, thanks for taking the time to report. If something displays some message somewhere, then please provide a clear and exact list of steps to reproduce which allow anyone else to reproduce the same problem, plus the exact message. Please see https://www.mediawiki.org/wiki/How_to_report_a_bug - thanks!

For the record, I believe this is about the OAuth dialog that appears right after you log in into the tool:

image.png (351×588 px, 37 KB)

Urbanecm changed the task status from Stalled to Open.Dec 9 2019, 10:19 PM
Urbanecm added a comment.Dec 9 2019, 10:53 PM

So, it's virtually the same permission as tools displaying this login dialog need:

image.png (284×594 px, 41 KB)

Agreed this looks less frightning than "some private data".

Urbanecm renamed this task from WatchTranslations requesting access to private data to Make WatchTranslations use identity-only email-allowed token.Dec 9 2019, 10:58 PM
Urbanecm claimed this task.
Urbanecm updated the task description. (Show Details)
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptDec 9 2019, 10:58 PM
Aklapper added a comment.Dec 9 2019, 11:00 PM
In T240258#5726137, @Urbanecm wrote:

For the record, I believe this is about the OAuth dialog that appears right after you log in into the tool:

Ah, thanks! I already logged in a while ago and forgot, so I could not find out which dialog this was about, as there was no complete error message in this task...

Urbanecm mentioned this in T240291: Migrate WatchTranslations from flask-mwoauth to python-mwoauth.Dec 9 2019, 11:00 PM
Urbanecm added a subtask: T240291: Migrate WatchTranslations from flask-mwoauth to python-mwoauth.
Urbanecm moved this task from Backlog to Blocked/External on the WatchTranslations board.
Bawolff subscribed.Dec 10 2019, 5:04 AM

I mean, email addresses are probably the most provate info we store, so the message seems fair to me. Maybe it should say something like e.g. email address & whatever else is included.

Urbanecm added a comment.Dec 10 2019, 7:26 AM
In T240258#5726842, @Bawolff wrote:

I mean, email addresses are probably the most provate info we store, so the message seems fair to me. Maybe it should say something like e.g. email address & whatever else is included.

Agreed, the wording can use "private information". On the other hand, it shouldn't use "private information" and nothing else. Why should an user assume IP address is not included in the box of forwarded information?

• Vargas04 triaged this task as Unbreak Now! priority.Dec 10 2019, 3:06 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptDec 10 2019, 3:06 PM
Nirmos lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 10 2019, 8:22 PM
Urbanecm moved this task from Backlog to Working on on the User-Urbanecm board.Dec 11 2019, 12:05 PM
Urbanecm closed subtask T240291: Migrate WatchTranslations from flask-mwoauth to python-mwoauth as Resolved.Dec 14 2019, 3:41 PM
• JFishback_WMF moved this task from Intake to Backlog on the Privacy board.Feb 4 2020, 11:29 PM
Urbanecm moved this task from Working on to Later on the User-Urbanecm board.Aug 10 2020, 9:52 PM
Urbanecm removed Urbanecm as the assignee of this task.Aug 10 2020, 9:53 PM

Not actively working at this task.

Tacsipacsi subscribed.Oct 31 2022, 7:06 PM
@Urbanecm moved this task from Backlog to Blocked/External on the WatchTranslations board.

Does this still apply? The subtask has been closed as resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits