Page MenuHomePhabricator

Clean up DNS server puppetization
Closed, ResolvedPublic

Description

A bunch of refactoring is due to clean up all the parts underneath role::dnsbox to better match coding standards and make more sense. I had been putting some of these commits into the Anycast AuthDNS ticket (T98006 ) , but really they belong in a separate subtask of it, so here it is.

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+50 -28
operations/puppetproduction+22 -0
operations/puppetproduction+12 -11
operations/puppetproduction+76 -73
operations/puppetproduction+0 -65
operations/puppetproduction+58 -64
operations/puppetproduction+73 -77
operations/puppetproduction+4 -7
operations/puppetproduction+8 -8
operations/puppetproduction+74 -85
operations/puppetproduction+6 -9
operations/puppetproduction+11 -11
operations/puppetproduction+18 -29
operations/puppetproduction+0 -9
operations/puppetproduction+1 -1
operations/puppetproduction+6 -0
operations/puppetproduction+11 -14
operations/puppetproduction+4 -21
operations/puppetproduction+11 -2
operations/puppetproduction+7 -7
operations/puppetproduction+22 -38
operations/puppetproduction+2 -1
operations/puppetproduction+1 -10
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 556081 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: remove host:53 monitor listener

https://gerrit.wikimedia.org/r/556081

Change 556082 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] dnsbox: move profile::standard up to role

https://gerrit.wikimedia.org/r/556082

Change 556081 merged by BBlack:
[operations/puppet@production] authdns: remove host:53 monitor listener

https://gerrit.wikimedia.org/r/556081

Change 556082 merged by BBlack:
[operations/puppet@production] dnsbox: move profile::standard up to role

https://gerrit.wikimedia.org/r/556082

Change 556083 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] dnsbox: remove include_auth switch

https://gerrit.wikimedia.org/r/556083

Change 556083 merged by BBlack:
[operations/puppet@production] dnsbox: remove include_auth switch

https://gerrit.wikimedia.org/r/556083

Change 556084 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] dnsrecursor: rename ulimits to override

https://gerrit.wikimedia.org/r/556084

Change 556085 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] dnsrecursor: add parameter bind_service

https://gerrit.wikimedia.org/r/556085

Change 556086 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] dnsbox: replace glue with bind_service

https://gerrit.wikimedia.org/r/556086

Change 556087 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] dnsbox: eliminate extra profile layer

https://gerrit.wikimedia.org/r/556087

Change 556084 merged by BBlack:
[operations/puppet@production] dnsrecursor: rename ulimits to override

https://gerrit.wikimedia.org/r/556084

Change 556085 merged by BBlack:
[operations/puppet@production] dnsrecursor: add parameter bind_service

https://gerrit.wikimedia.org/r/556085

Change 556086 merged by BBlack:
[operations/puppet@production] dnsbox: replace glue with bind_service

https://gerrit.wikimedia.org/r/556086

Change 556087 merged by BBlack:
[operations/puppet@production] dnsbox: eliminate extra profile layer

https://gerrit.wikimedia.org/r/556087

Change 556183 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] dnsrecursor: remove redundant listen for prod case

https://gerrit.wikimedia.org/r/556183

Change 556183 merged by BBlack:
[operations/puppet@production] dnsrecursor: remove redundant listen for prod case

https://gerrit.wikimedia.org/r/556183

Change 556387 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: fix comment in scripts.pp

https://gerrit.wikimedia.org/r/556387

Change 556388 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: remove stretch clause

https://gerrit.wikimedia.org/r/556388

Change 556387 merged by BBlack:
[operations/puppet@production] authdns: fix comment in scripts.pp

https://gerrit.wikimedia.org/r/556387

Change 556388 merged by BBlack:
[operations/puppet@production] authdns: remove stretch clause

https://gerrit.wikimedia.org/r/556388

Change 556394 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: move global monitoring to profile

https://gerrit.wikimedia.org/r/556394

Change 556395 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: move host monitoring to profile

https://gerrit.wikimedia.org/r/556395

Change 556396 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: refactor conf monitoring

https://gerrit.wikimedia.org/r/556396

Change 556394 merged by BBlack:
[operations/puppet@production] authdns: move global monitoring to profile

https://gerrit.wikimedia.org/r/556394

Change 556395 merged by BBlack:
[operations/puppet@production] authdns: move host monitoring to profile

https://gerrit.wikimedia.org/r/556395

Change 556396 merged by BBlack:
[operations/puppet@production] authdns: refactor conf monitoring

https://gerrit.wikimedia.org/r/556396

Change 556406 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: move discovery to profile and refactor

https://gerrit.wikimedia.org/r/556406

Change 556406 merged by BBlack:
[operations/puppet@production] authdns: move discovery to profile and refactor

https://gerrit.wikimedia.org/r/556406

Change 556423 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: move discovery check out of scripts

https://gerrit.wikimedia.org/r/556423

Change 556424 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: invert require on exec

https://gerrit.wikimedia.org/r/556424

Change 556423 merged by BBlack:
[operations/puppet@production] authdns: move discovery check out of scripts

https://gerrit.wikimedia.org/r/556423

Change 556424 merged by BBlack:
[operations/puppet@production] authdns: invert require on exec

https://gerrit.wikimedia.org/r/556424

Change 556429 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: move config to profile

https://gerrit.wikimedia.org/r/556429

Change 556430 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: move update system to profile and refac

https://gerrit.wikimedia.org/r/556430

Change 556429 merged by BBlack:
[operations/puppet@production] authdns: move config to profile

https://gerrit.wikimedia.org/r/556429

Change 556430 merged by BBlack:
[operations/puppet@production] authdns: move update system to profile and refac

https://gerrit.wikimedia.org/r/556430

Change 556435 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] authdns: get rid of spec test stuff

https://gerrit.wikimedia.org/r/556435

Change 556435 merged by BBlack:
[operations/puppet@production] authdns: get rid of spec test stuff

https://gerrit.wikimedia.org/r/556435

Change 556447 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] p::dns::auth: split up the monolith

https://gerrit.wikimedia.org/r/556447

Change 556448 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] p::dns::auth: remove create_resources use

https://gerrit.wikimedia.org/r/556448

Change 556447 merged by BBlack:
[operations/puppet@production] p::dns::auth: split up the monolith

https://gerrit.wikimedia.org/r/556447

Change 556448 merged by BBlack:
[operations/puppet@production] p::dns::auth: remove create_resources use

https://gerrit.wikimedia.org/r/556448

Change 556491 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] ferm: add destination support to services

https://gerrit.wikimedia.org/r/556491

Change 556492 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] Refactor DNS ferm rules

https://gerrit.wikimedia.org/r/556492

Change 556491 merged by BBlack:
[operations/puppet@production] ferm: add destination support to services

https://gerrit.wikimedia.org/r/556491

Change 556492 merged by BBlack:
[operations/puppet@production] Refactor DNS ferm rules

https://gerrit.wikimedia.org/r/556492

Change 556498 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] p::dns::recursor: bugfix for new ferm rules

https://gerrit.wikimedia.org/r/556498

Change 556498 merged by BBlack:
[operations/puppet@production] p::dns::recursor: bugfix for new ferm rules

https://gerrit.wikimedia.org/r/556498

Change 556500 had a related patch set uploaded (by BBlack; owner: BBlack):
[operations/puppet@production] p::dns::recursor: bugfix for new ferm rules

https://gerrit.wikimedia.org/r/556500

Change 556500 merged by BBlack:
[operations/puppet@production] p::dns::recursor: bugfix for new ferm rules

https://gerrit.wikimedia.org/r/556500

The new puppetization has been stable for quite a while now, we can resolve this, as it's kind of ambiguous what if any further improvements are warranted outside of any specific future feature / arch changes.