Page MenuHomePhabricator

Use wfClientAcceptsGzip() in wfGzipHandler
Closed, ResolvedPublic


Use wfClientAcceptsGzip() in wfGzipHandler

wfGzipHandler should use wfClientAcceptsGzip() instead of reimplement it itself.
Attached patch does it, and removes the $wgUseGzip check on wfClientAcceptsGzip() since HTMLFileCache (the only wfClientAcceptsGzip() user) already checked that before calling it. This way $wgUseGzip stays applying only for file cache, and $wgDisableOutputCompression for output handler.

Version: 1.16.x
Severity: enhancement

attachment bug 22034.patch ignored as obsolete



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:53 PM
bzimport set Reference to bz22034.
bzimport added a subscriber: Unknown Object (MLST).

Reverted in r60871. Causes PHP Notice: Undefined index: HTTP_ACCEPT_ENCODING in GlobalFunctions.php on line 1175

Second version of the patch