Page MenuHomePhabricator

CU 2.0: Figure out how to do tabs in a special page
Closed, ResolvedPublic

Description

Acceptance criteria:
  • Figure out a strategy to do tabs in CU for the Preliminary check, Compare and Timeline tabs
  • Create follow-up task(s) to work on

Event Timeline

• Niharika triaged this task as Medium priority.

Perhaps using OOUI IndexLayout and TabPanelLayout?

@Niharika Do you mean as far as design (HTML, CSS) or functionality (subpage, etc.)?

@Niharika Do you mean as far as design (HTML, CSS) or functionality (subpage, etc.)?

The latter. We split this task out from another during an estimation. @dmaza, @Tchanders and @Mooeypoo had some ideas about this.

The latter. We split this task out from another during an estimation. @dmaza, @Tchanders and @Mooeypoo had some ideas about this.

Oh ok, yeah my assumption was that they were going to be subpages off of the special page.

• Niharika renamed this task from CU 2.0: Figure out how to do tabs in a special page to [Spike: 4 hours] CU 2.0: Figure out how to do tabs in a special page.Jan 23 2020, 7:16 PM
• Niharika added a project: Spike.
• Niharika updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptJan 23 2020, 7:16 PM

Change 570698 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Add Tabs to Special:Investigate

https://gerrit.wikimedia.org/r/570698

dbarratt renamed this task from [Spike: 4 hours] CU 2.0: Figure out how to do tabs in a special page to CU 2.0: Figure out how to do tabs in a special page.Feb 6 2020, 9:14 PM
• Niharika changed the subtype of this task from "Spike" to "Task".Feb 6 2020, 10:31 PM

Change 571794 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Fix tab styles on Special:Investigate

https://gerrit.wikimedia.org/r/571794

Change 570698 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add Tabs to Special:Investigate

https://gerrit.wikimedia.org/r/570698

Change 571794 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Fix tab styles on Special:Investigate

https://gerrit.wikimedia.org/r/571794

dom_walden subscribed.

Tabs seem to work fine.

Tested on Firefox and Chrome.

Version: MediaWiki 1.35.0-alpha (7deb1cf), CheckUser 2.5 (fc9c7f5) 08:38, 21 February 2020