Page MenuHomePhabricator

Maxlag=5 for Author Disambiguator
Closed, ResolvedPublic

Description

Author Disambiguator edits go through even if maxlag is higher than 5, we should fix the code to ensure it complies with the maxlag policy on Wikimedia wikis by using maxlag=5 (or a lower value) on all editing API queries.

Event Timeline

Pintoch created this task.Dec 10 2019, 7:54 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Dec 11 2019, 11:41 AM
Bugreporter added a subscriber: Bugreporter.EditedDec 11 2019, 2:30 PM

In the patch using higher maxlag value is removed but default $iterations_left (5) is not increased. This will result in the issue described in T221774#5679442. The tool should cope with high maxlag for up to one hour.

(A) Pintoch's patch has been applied, and (B) I also increased the retry time from 5 seconds to 5 minutes - that still means an edit will fail after 25 minutes if maxlag doesn't drop, with only 5 retries. Is there a consensus to retry for an hour? Or if there's a better standard for handling retries let me know!

I increased the default number of retries to 12, so it will now retry for up to an hour. I think we're good here?

ArthurPSmith closed this task as Resolved.Dec 11 2019, 3:36 PM

Marking as resolved...