Page MenuHomePhabricator

VE shoudn't replace empty values with autovalue in parameters that already exist
Closed, InvalidPublic2 Estimated Story PointsBUG REPORT

Description

Now, if the field is empty, the VisualEditor replaces it with autovalue. This is completely unintuitive behavior for the user who is editing the template. The user opens the template, makes an edit in one or two fields, and when saved, it turns out that significantly more fields have changed. The user does not suspect this, because he sees already substituted values immediately upon opening.

Autovalue should only be substituted when the user explicitly adds a field. Otherwise, the editor spoils the article.

There is an example (one of many) in the screenshot when the user changes only the image, and receives a lot of changed fields.

ve_autovalue_diff.png (986×1 px, 151 KB)

TODO:

  • Try to reproduce the problem. It's most probably resolved by now.
  • Check the history of https://ru.wikipedia.org/wiki/Шаблон:Музыкант if something suspicious changed around 2019-12-10.
  • Possibly try to find the moment in the Git history when this was broken, somewhere around 2019-12-10.

Event Timeline

putnik renamed this task from No need to replace empty values with autovalue in parameters that already exist to VE shoudn't replace empty values with autovalue in parameters that already exist.Dec 10 2019, 7:55 PM
thiemowmde changed the subtype of this task from "Task" to "Bug Report".
thiemowmde added subscribers: thiemowmde, Lena_WMDE.

Try to reproduce the problem. It's most probably resolved by now.

Could not reproduce this. Might be solved.

Check the history of https://ru.wikipedia.org/wiki/Шаблон:Музыкант if something suspicious changed around 2019-12-10.

Nothing suspicious to see here really.

Possibly try to find the moment in the Git history when this was broken, somewhere around 2019-12-10.

Checked commits from 2019-11 to 2019-12 in VE extension. Nothing that seems relevant to autovalue or even templates.

This issue seems to be fixed. Please comment here or re-open the ticket if it occurs again.

WMDE-Fisch set the point value for this task to 2.Jan 31 2022, 11:27 AM