Page MenuHomePhabricator

URLs for "Related Gerrit Patches" are cut off on mobile and not shown
Closed, ResolvedPublic

Assigned To
Authored By
Kizule
Dec 11 2019, 12:39 AM
Referenced Files
F31817581: Screenshot_20200514_120610_com.android.chrome.jpg
May 14 2020, 10:07 AM
F31477688: Screenshot_20191216-132200.jpg
Dec 16 2019, 12:27 PM
F31468061: Screenshot_20191211-014224.jpg
Dec 11 2019, 12:44 AM
F31468059: Screenshot_20191211-013657.jpg
Dec 11 2019, 12:43 AM
F31468051: Screenshot_20191211-013621.jpg
Dec 11 2019, 12:39 AM
F31468052: Screenshot_20191211-013657.jpg
Dec 11 2019, 12:39 AM
Subscribers

Description

When I open any task on Phabricator, there are "Related Gerrit Patches". On mobile, I don't have on what to click:

Screenshot_20191211-013621.jpg (1×720 px, 130 KB)

On version for PC/on PC, it is avaiable:

Screenshot_20191211-013657.jpg (1×720 px, 255 KB)

Event Timeline

Version of browser, Android...

Screenshot_20191211-014224.jpg (1×720 px, 93 KB)

(I don't know why my phone is called Huawei ATU-L21.. Real name is Huawei Y6 2018.. But this isn't question to someone for Wikimedia, this is just a note :). )

JJMC89 renamed this task from On Mobile aren't avaiable URLs for "Related Gerrit Patches" to URLs for "Related Gerrit Patches" URLs aren't available on mobile.Dec 11 2019, 1:09 AM
JJMC89 renamed this task from URLs for "Related Gerrit Patches" URLs aren't available on mobile to URLs for "Related Gerrit Patches" aren't available on mobile.
Aklapper renamed this task from URLs for "Related Gerrit Patches" aren't available on mobile to URLs for "Related Gerrit Patches" are cut off on mobile and not shown.Dec 11 2019, 10:57 AM
Aklapper added a project: Mobile.

It's a table, as it is tabular data. :) Code is in https://phabricator.wikimedia.org/rPHEX7a526af8b46c0b9a0aacd3270a3bc3323ce51a2c

I wonder if we could somewhere sneak in

@media(max-width: 480px) {
  td { display: table-row; }
}

but probably hard to define a value (example: 480px) that makes sense in most cases, as repo names could be any length

It's a table, as it is tabular data. :) Code is in https://phabricator.wikimedia.org/rPHEX7a526af8b46c0b9a0aacd3270a3bc3323ce51a2c

I wonder if we could somewhere sneak in

@media(max-width: 480px) {
  td { display: table-row; }
}

but probably hard to define a value (example: 480px) that makes sense in most cases, as repo names could be any length

Your comment have sense. I can still reproduce this on task from screenshot, but in T240799 things looks a bit better.

Screenshot_20191216-132200.jpg (1×720 px, 189 KB)

Maybe we should just add for mobiles scrolling LTR.

Looks like that this is somehow resolved.

See:

Screenshot_20200514_120610_com.android.chrome.jpg (1×720 px, 352 KB)

Now I can scroll in each task.

Aklapper assigned this task to mmodell.

Nice catch Zoranzoki21! :)
Right, since https://phabricator.wikimedia.org/rPHEX31beeaa265bca3e28d13360c91b1c57eb6c85bc5 it uses an AphrontTableView it seems.