Page MenuHomePhabricator

Check return value of hook SpecialContributionsBeforeMainOutput in SpecialContributions
Closed, ResolvedPublic

Description

The return value of hook SpecialContributionsBeforeMainOutput in SpecialContributions is not checked. This means, that external users using this hook can currently not return a false value in order to abort the main processing (rendering the form and list of contribution).

I added an if() statement - see patch - in conformity to similar hooks in other modules.

With the patch, "false" stopps the processing.


Version: 1.16.x
Severity: normal

Details

Reference
bz22051

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:54 PM
bzimport set Reference to bz22051.
bzimport added a subscriber: Unknown Object (MLST).
Wikinaut created this task.Jan 8 2010, 7:44 AM

Created attachment 6938
Patch

Attached:

IAlex added a comment.Jan 8 2010, 9:01 PM

Fixed in r60848.