Page MenuHomePhabricator

Check user has right to edit the page before showing 'Reply' buttons
Closed, ResolvedPublic

Description

It is much less common that a user would not be allowed to edit a talk page than an article page, but it does happen. In this case we should not show reply links.

Event Timeline

Esanders renamed this task from Check has user and edit rights before showing 'Reply' buttons to Check user has right to edit the page before showing 'Reply' buttons.Dec 12 2019, 4:01 PM

Change 578596 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Check wgIsProbablyEditable before showing 'Reply' buttons

https://gerrit.wikimedia.org/r/578596

Change 578596 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Check wgIsProbablyEditable before showing 'Reply' buttons

https://gerrit.wikimedia.org/r/578596

@Esanders: do you have an example page handy where I can test this?

I tried to test it as a logged out user on a protected page, but I guess the talk page for a protected article can still be editable by that user, so it's showing the reply links.

I don't know how to find out protected talk pages.

matmarex added a project: Editing QA.

You can use Special:ProtectedPages to find some. (Or just make one and protect it, at least on Beta, let me know if you don't have some user rights and I can grant them.) And yes, talk pages and their corresponding article pages are protected separately.

Here are some examples:

@matmarex: I tried couple of protected talk pages on Dutch wiki, but I am still getting Reply links on those. I tested on the following pages:

https://nl.wikipedia.org/wiki/Overleg:Fred_van_der_Wal?dtenable=1
https://nl.wikipedia.org/w/index.php?title=Overleg:De_Chninkel&dtenable=1

Depending on their protection level, your account might still be able to edit them… :) Try it when logged out.

no wait, I tested while I was logged in (my account probably has some special rights that I don't know of/use?).
When I tried as an anonymous user, it's not showing Reply links anymore on those protected pages.

Depending on their protection level, your account might still be able to edit them… :) Try it when logged out.

yes :P