Page MenuHomePhabricator
Create Task
Maniphest T240624

Style desktop Minerva diff page to look like Special:MobileDiff
Open, Needs TriagePublic
Actions

Description

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Spain&type=revision&diff=400071&oldid=397846&diffmode=source&useskin=minerva looks very different from https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/400071

Let's converge these pages and styles (when running in mobile mode) so that Special:MobileDiff is no longer needed and thus can be removed.

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenNoneT12863 Links on commons upload summaries do not link to commons
 OpenNoneT5498 Image history is confusing
 StalledNoneT96384 Integrate file revisions with description page history
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 OpenNoneT39534 Wikimedia Commons should support searching by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 OpenNoneT122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
 OpenNoneT135221 Make TimedText content an integral part of the File page
 OpenNoneT2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
 OpenNoneT132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
 ResolvedppelbergT54448 Transclusion dialog should not suggest documentation sub pages as templates
 ResolvedKrinkleT52512 TemplateData: Page properties should not be stored twice (both Template and Template/doc)
 OpenNoneT56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 ResolvedHalfakT252280 Improve Wikilabels UI
 OpenNoneT105518 Make Wiki Labels mobile compatible
OpenNoneT104072 Implement single column diff option (from mobile app)
 StalledNoneT174043 Deploy Multi-Content Revisions
 OpenNoneT203157 Make the spam whitelist its own slot
 OpenNoneT174022 Implement multi-content revisions
 OpenNoneT189220 Ensure that relevant extensions are MCR-aware
 OpenNoneT202763 Update extensions which customize content diff rendering
 OpenNoneT94370 Implement a mechanism that recognizes syntax errors of wikicode as a Huggle extension
 ResolvedPetrbT57793 Scoring should perhaps take into account added text rather than all text
 OpenNoneT100082 Provide useful diffs to high-volume consumers of recent changes
 OpenNoneT56328 Provide intraline diff format in API action=compare
 OpenNoneT162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
 OpenNoneT238507 MobileFrontend sometimes goes to diff page instead of pending changes review page
 OpenNoneT117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
 OpenNoneT240624 Style desktop Minerva diff page to look like Special:MobileDiff

Event Timeline

Jdlrobson created this task.Dec 12 2019, 9:22 PM
Jdlrobson edited projects, added MinervaNeue; removed Platform Team Workboards (Clinic Duty Team), Desktop Improvements, TechCom, MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions.
Ladsgroup added a comment.Dec 13 2019, 9:16 AM

I might be wrong here but the diff with mobile with #e07076 and #222 violates AAA WCAG contrast check, also the color of none of the diffs are from the color palette.

Jdlrobson added a comment.Dec 13 2019, 6:40 PM
In T240624#5738715, @Ladsgroup wrote:

I might be wrong here but the diff with mobile with #e07076 and #222 violates AAA WCAG contrast check, also the color of none of the diffs are from the color palette.

Right now I'm just focused on the technical parts. We can ship different diff colors on a different skin or we can keep them the same.
The issue you talk about is in T90948

Jdlrobson moved this task from Inbox to Next up on the User-Jdlrobson board.Jan 7 2020, 12:45 AM
Jdlrobson moved this task from Backlog to Tech debt on the MinervaNeue board.Jan 17 2020, 11:15 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL