⚓ T240639 Highlighting of the replies is incorrect on Beta cluster

	Subject	Repo	Branch	Lines +/-
	Attach highlights to positioned container	mediawiki/extensions/DiscussionTools	master	+4 -2

Status	Assigned	Task
Open	None	T233443 [Epic] Reply Tool
Resolved	ppelberg	T235923 Replies v1.0: release replying to specific comments
Resolved	• iamjessklein	T236921 Replies v1.0: conduct usability testing
Resolved	Ryasmeen	T239961 QA Replying v1.0 on prototype server
Resolved	Esanders	T240639 Highlighting of the replies is incorrect on Beta cluster

Ryasmeen created this task.Dec 12 2019, 11:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2019, 11:12 PM

Ryasmeen added projects: VisualEditor, DiscussionTools.Dec 12 2019, 11:13 PM

Ryasmeen added a parent task: T239961: QA Replying v1.0 on prototype server.

For me, it doesn’t highlight at all (FF 68.3 ESR on Debian). I see

TypeError: range.cloneRange is not a function

caused by the

RangeFix.getBoundingClientRect( $pageContainer[ 0 ] )

added as controller.js’s line 133 in a6147ff. I’m not very surprised, as [[https://github.com/edg2s/rangefix/blob/f8b143cedd259250af4ee1938a300bc92f0449bb/rangefix.js#L208|RangeFix.getBoundingClientRect]] expects a Range parameter, not an HTMLElement one ($pageContainer is initialized—through various function calls—as $('#mw-content-text')). How much I love JavaScript’s complete lack of static typing…

ppelberg mentioned this in T235923: Replies v1.0: release replying to specific comments.Jan 8 2020, 1:07 AM

ppelberg edited projects, added VisualEditor (Current work); removed VisualEditor.

In T240639#5758939, @Tacsipacsi wrote:

For me, it doesn’t highlight at all (FF 68.3 ESR on Debian). I see

TypeError: range.cloneRange is not a function

Thanks, I've fixed that in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DiscussionTools/+/565047/, but it seems unrelated to this bug.

The issue here is that the highlight is positioned relative to .mw-parser-output, but that is not position:relative.

Esanders claimed this task.Jan 15 2020, 4:07 PM

Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Change 565050 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Attach highlights to positioned container

https://gerrit.wikimedia.org/r/565050

gerritbot added a project: Patch-For-Review.Jan 15 2020, 4:08 PM

Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Jan 15 2020, 4:08 PM

Change 565050 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Attach highlights to positioned container

https://gerrit.wikimedia.org/r/565050

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Jan 30 2020, 12:13 AM

matmarex removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 30 2020, 1:01 AM

matmarex added a project: Editing QA.Feb 3 2020, 6:52 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Feb 3 2020, 11:22 PM

Ryasmeen edited projects, added Verified; removed Editing QA.

JTannerWMF added a project: Editing-team (Q3 2019-2020 Kanban Board).Feb 4 2020, 10:15 PM