Page MenuHomePhabricator
Create Task
Maniphest T240669

Make popper reusable
Closed, ResolvedPublic
Actions

Description

I suspect it should take three parameters:

  • The string for the title (probably as a prop)
  • The content in the subheader area (as named slot)
  • The content of the body (as a named slot)

We think that things like:

  • Text size of the header
  • Bold text-ness of the header
  • The close button
  • The line

will all stay constant.

image.png (557×823 px, 512 KB)

Details

SubjectRepoBranchLines +/-
TR: Create TaintedPopper componentmediawiki/extensions/Wikibasemaster+240 -70
TR: Extract subheading line from Poppermediawiki/extensions/Wikibasemaster+68 -60
TR: Popper to now take title as a propmediawiki/extensions/Wikibasemaster+48 -26
Customize query in gerrit

Event Timeline

Tarrow created this task.Dec 13 2019, 11:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2019, 11:01 AM
hoo subscribed.Dec 13 2019, 11:11 AM

I just talked to @Tarrow about this, and for now it should be enough to use that new component directly in App.vue, but if that turns out to bloat App.vue to much we will revisit this.

Potential further break downs could be to separate out the popper header and body area.

hoo claimed this task.Dec 16 2019, 12:20 PM
hoo moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint7 board.
Tarrow claimed this task.Jan 2 2020, 8:03 PM

Stole this to work on before the winter break ends

WMDE-leszek added a project: Wikidata-Tainted-References-Sprint8.Jan 6 2020, 10:35 AM
WMDE-leszek moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint8 board.
gerritbot added a comment.Jan 6 2020, 12:51 PM

Change 562249 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Popper to now take title as a prop

https://gerrit.wikimedia.org/r/562249

gerritbot added a project: Patch-For-Review.Jan 6 2020, 12:51 PM

Change 562250 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Extract subheading line from Popper

https://gerrit.wikimedia.org/r/562250

gerritbot added a comment.Jan 6 2020, 12:51 PM

Change 562252 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Create TaintedPopper component

https://gerrit.wikimedia.org/r/562252

gerritbot added a comment.Jan 8 2020, 10:42 AM

Change 562249 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Popper to now take title as a prop

https://gerrit.wikimedia.org/r/562249

gerritbot added a comment.Jan 8 2020, 10:42 AM

Change 562250 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Extract subheading line from Popper

https://gerrit.wikimedia.org/r/562250

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 8 2020, 11:00 AM
gerritbot added a comment.Jan 8 2020, 5:04 PM

Change 562252 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Create TaintedPopper component

https://gerrit.wikimedia.org/r/562252

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2020, 5:10 PM
hoo moved this task from Doing to Done on the Wikidata-Tainted-References-Sprint8 board.Jan 8 2020, 9:18 PM

I think we're done as far as this task goes, the popper is now a easily-reusable component within our source tree (pulling it out would be trivial, but is out of scope here).

Tarrow closed this task as Resolved.Jan 13 2020, 10:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL