Saving an edit with no change gives nonsense error message
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Dec 13 2019, 7:50 PM

Description

Problem

If you try to save a watched component and make no change, you'll get "Could not edit: would create a duplicate watched component".

Proposed solution

Make the tool either say "no change" or throw a success message.

Student is expected to upload a patch against labs/tools/watch-translations repository at Wikimedia Gerrit. Student should claim Phabricator task while claiming task at the GCI site.

Materials

Details

	Subject	Repo	Branch	Lines +/-
	Add specific message for no change error	labs/tools/watch-translations	master	+6 -1

Customize query in gerrit

Event Timeline

Urbanecm created this task.Dec 13 2019, 7:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2019, 7:50 PM

Claiming as part of Google Code-In 2019.

Change 557631 had a related patch set uploaded (by RetroCraft; owner: RetroCraft):
[labs/tools/watch-translations@master] Add specific message for no change error

https://gerrit.wikimedia.org/r/557631

gerritbot added a project: Patch-For-Review.Dec 15 2019, 7:05 PM

Change 557631 merged by jenkins-bot:
[labs/tools/watch-translations@master] Add specific message for no change error

https://gerrit.wikimedia.org/r/557631

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2019, 9:10 PM

Kizule closed this task as Resolved.Dec 15 2019, 9:16 PM