Page MenuHomePhabricator

Create a jenkins section for phan
Closed, ResolvedPublic

Description

Currently, the phan job has a single section, "setup quibble", which is autocollapsed. However, since phan is executed within that section, the results are not visible if you don't click "Show details", see e.g. https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/25540/console.

Event Timeline

hashar subscribed.

Phan is run after Quibble which outputs markers that can be parsed by Jenkins see T220586. Turns out that got broken when we last upgraded Quibble. So you should see a few more sections now at https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/lastSuccessfulBuild/console

For Phan I am not sure at which point we should open a section. Maybe based on the docker run docker-registry.wikimedia.org/releng/mediawiki-phan or on exec vendor/bin/phan.

Another alternative is that Phan generates checkstyle. IIRC Phan 1.x introduced a way to save the checkstyle report to a file. We could then have Jenkins analyze the output which would show up on the build page eg: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/lastSuccessfulBuild/ and would be arguably nicer than pointing at the console :]

Phan is run after Quibble which outputs markers that can be parsed by Jenkins see T220586. Turns out that got broken when we last upgrade Quibble. So you should see a few more sections now at https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/lastSuccessfulBuild/console

Yeah, it's much better now! The main problem was the section being autocollapsed, which has since been resolved.

For Phan I am not sure at which point we should open a section. Maybe based on the docker run docker-registry.wikimedia.org/releng/mediawiki-phan or on exec vendor/bin/phan.

I don't know what the default is, but both seem sensible. Also, it's just a matter of a handful of lines in between.

Another alternative is that Phan generates checkstyle. IIRC Phan 1.x introduced a way to save the checkstyle report to a file. We could then have Jenkins analyze the output which would show up on the build page eg: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/lastSuccessfulBuild/ and would be arguably nicer than pointing at the console :]

I think this would be the same that you mentioned at T224821#5229782? It seems that's supported in the phan version we're using.

hashar claimed this task.

@Daimona, thank you. So it looks like this task is complete after I fixed the collapsible section regex.

I have created a new task to support checkstyle based on the comment you mentioned: T259890

Please reopen if I have missed something ;)