Page MenuHomePhabricator
Create Task
Maniphest T240766

Refactor TemplateWizard Selenium tests
Closed, ResolvedPublic
Actions

Description

Refactor selenium tests. These tests have numerous anti-patterns. Refactoring them will allow them to be more easily understood and able to run in parallel.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Ephemeralwaves created this task.Dec 14 2019, 9:31 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptDec 14 2019, 9:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 14 2019, 9:36 PM

Change 557278 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: refactor TemplateWizard.js test

https://gerrit.wikimedia.org/r/557278

gerritbot added a project: Patch-For-Review.Dec 14 2019, 9:36 PM
gerritbot added a comment.Dec 15 2019, 7:38 PM

Change 557634 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: refactor TemplateWizard.js test

https://gerrit.wikimedia.org/r/557634

zeljkofilipin triaged this task as Medium priority.Dec 16 2019, 2:11 PM
zeljkofilipin added a project: User-zeljkofilipin.
zeljkofilipin moved this task from Backlog 🪒 to Q3 👔 on the User-zeljkofilipin board.
gerritbot added a comment.Jan 13 2020, 6:34 PM

Change 557634 abandoned by Zfilipin:
Selenium: refactor TemplateWizard.js test

Reason:
We've agreed in a meeting to rewrite this as a series of smaller patches.

https://gerrit.wikimedia.org/r/557634

gerritbot added a comment.Jan 13 2020, 6:34 PM

Change 557278 abandoned by Zfilipin:
Selenium: refactor TemplateWizard.js test

Reason:
We've agreed in a meeting to rewrite this as a series of smaller patches.

https://gerrit.wikimedia.org/r/557278

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2020, 7:10 PM
gerritbot added a comment.Jan 15 2020, 3:51 PM

Change 565046 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: fix test

https://gerrit.wikimedia.org/r/565046

gerritbot added a project: Patch-For-Review.Jan 15 2020, 3:51 PM
zeljkofilipin moved this task from Q3 👔 to Deep work 🌊 on the User-zeljkofilipin board.Jan 15 2020, 4:01 PM
gerritbot added a comment.Jan 15 2020, 4:11 PM

Change 565053 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: break up test

https://gerrit.wikimedia.org/r/565053

gerritbot added a comment.Jan 15 2020, 4:16 PM

Change 565054 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: remove extraneous code

https://gerrit.wikimedia.org/r/565054

gerritbot added a comment.Jan 15 2020, 5:29 PM

Change 565068 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: add page object

https://gerrit.wikimedia.org/r/565068

gerritbot added a comment.Jan 20 2020, 3:07 PM

Change 565046 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Selenium: fix test

https://gerrit.wikimedia.org/r/565046

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 20 2020, 4:00 PM
gerritbot added a comment.Jan 23 2020, 7:54 PM

Change 565068 abandoned by Ephemeralwaves:
Selenium: add page object

Reason:
Patch is too big. Will work on smaller patch.

https://gerrit.wikimedia.org/r/565068

gerritbot added a comment.Jan 23 2020, 8:14 PM

Change 566864 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: add page object

https://gerrit.wikimedia.org/r/566864

gerritbot added a comment.Jan 23 2020, 8:14 PM

Change 566865 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: add page object

https://gerrit.wikimedia.org/r/566865

gerritbot added a comment.Jan 23 2020, 8:15 PM

Change 566864 abandoned by Ephemeralwaves:
Selenium: add page object

Reason:
Accidentally added this, fixed it here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TemplateWizard/ /566865/

https://gerrit.wikimedia.org/r/566864

gerritbot added a comment.Jan 23 2020, 8:23 PM

Change 566865 abandoned by Ephemeralwaves:
Selenium: add page object

https://gerrit.wikimedia.org/r/566865

gerritbot added a comment.Jan 23 2020, 8:24 PM

Change 566868 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: add page object

https://gerrit.wikimedia.org/r/566868

zeljkofilipin moved this task from Deep work 🌊 to Q3 👔 on the User-zeljkofilipin board.Feb 5 2020, 3:24 PM
zeljkofilipin moved this task from Q3 👔 to Backlog 🪒 on the User-zeljkofilipin board.Feb 14 2020, 12:54 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.Feb 17 2020, 4:26 PM
gerritbot added a comment.Feb 20 2020, 4:48 AM

Change 565053 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Selenium: break up test

https://gerrit.wikimedia.org/r/565053

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Feb 20 2020, 5:00 AM
gerritbot added a comment.Feb 20 2020, 11:39 AM

Change 565054 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Selenium: remove extraneous code

https://gerrit.wikimedia.org/r/565054

gerritbot added a comment.Feb 24 2020, 5:59 PM

Change 566868 abandoned by Ephemeralwaves:
Selenium: add page object

https://gerrit.wikimedia.org/r/566868

gerritbot added a comment.Feb 24 2020, 6:00 PM

Change 574515 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: add page object

https://gerrit.wikimedia.org/r/574515

zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.Mar 2 2020, 5:42 PM
zeljkofilipin moved this task from Watching 📺 to Learn/Teach 💡 on the User-zeljkofilipin board.Mar 18 2020, 2:29 PM
gerritbot added a comment.Apr 7 2020, 2:26 AM

Change 574515 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Selenium: add page object

https://gerrit.wikimedia.org/r/574515

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.27; 2020-04-07); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Apr 7 2020, 3:01 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 7 2020, 3:10 AM
gerritbot added a comment.Apr 27 2020, 12:02 AM

Change 592508 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: add page object

https://gerrit.wikimedia.org/r/592508

gerritbot added a project: Patch-For-Review.Apr 27 2020, 12:02 AM
gerritbot added a comment.May 16 2020, 8:59 PM

Change 596821 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateWizard into review/ephemeralwaves/T240766

https://gerrit.wikimedia.org/r/596821

gerritbot added a comment.May 16 2020, 9:03 PM

Change 596821 abandoned by Ephemeralwaves:
Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateWizard into review/ephemeralwaves/T240766

https://gerrit.wikimedia.org/r/596821

gerritbot added a comment.May 24 2020, 2:52 AM

Change 598220 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: move helper function

https://gerrit.wikimedia.org/r/598220

gerritbot added a comment.May 25 2020, 1:47 PM

Change 592508 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Selenium: add page object

https://gerrit.wikimedia.org/r/592508

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).May 25 2020, 2:00 PM
zeljkofilipin moved this task from Learn/Teach 💡 to Recurring ♻️ on the User-zeljkofilipin board.May 25 2020, 2:02 PM
gerritbot added a comment.May 29 2020, 4:20 PM

Change 598220 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Selenium: move helper function

https://gerrit.wikimedia.org/r/598220

Maintenance_bot removed a project: Patch-For-Review.May 29 2020, 5:10 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.35; 2020-06-02); removed MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 30 2020, 8:03 AM
gerritbot added a comment.May 30 2020, 11:44 PM

Change 600478 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: add iterator

https://gerrit.wikimedia.org/r/600478

gerritbot added a project: Patch-For-Review.May 30 2020, 11:44 PM
gerritbot added a comment.Jun 1 2020, 3:54 PM

Change 600478 merged by jenkins-bot:
[mediawiki/extensions/TemplateWizard@master] Selenium: add iterator

https://gerrit.wikimedia.org/r/600478

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2020, 4:11 PM
gerritbot added a comment.Jun 12 2020, 2:23 PM

Change 605238 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: split last test

https://gerrit.wikimedia.org/r/605238

gerritbot added a project: Patch-For-Review.Jun 12 2020, 2:23 PM
gerritbot added a comment.Jun 20 2020, 11:37 PM

Change 606802 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: split last test

https://gerrit.wikimedia.org/r/606802

gerritbot added a comment.Sep 10 2020, 6:06 PM

Change 626458 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: Template insertion dialog error test

https://gerrit.wikimedia.org/r/626458

gerritbot added a comment.Sep 10 2020, 6:06 PM

Change 606802 abandoned by Ephemeralwaves:
[mediawiki/extensions/TemplateWizard@master] Selenium: split last test

Reason:
Rewrote test https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateWizard/ /626458

https://gerrit.wikimedia.org/r/606802

gerritbot added a comment.Sep 10 2020, 7:31 PM

Change 626479 had a related patch set uploaded (by Ephemeralwaves; owner: Ephemeralwaves):
[mediawiki/extensions/TemplateWizard@master] Selenium: Template insertion death date field test

https://gerrit.wikimedia.org/r/626479

gerritbot added a comment.Sep 10 2020, 7:32 PM

Change 605238 abandoned by Ephemeralwaves:
[mediawiki/extensions/TemplateWizard@master] Selenium: death date in focus test

Reason:
Redid this patch

https://gerrit.wikimedia.org/r/605238

zeljkofilipin moved this task from Recurring ♻️ to Learn/Teach 💡 on the User-zeljkofilipin board.Dec 22 2020, 6:46 PM
zeljkofilipin mentioned this in T272142: Mentor coworkers, volunteers and interns.Jan 15 2021, 12:44 PM
zeljkofilipin moved this task from Learn/Teach 💡 to Deep work 🌊 on the User-zeljkofilipin board.Mar 22 2021, 6:50 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.Mar 23 2021, 2:53 PM
gerritbot added a comment.Mar 24 2021, 3:27 PM

Change 626479 abandoned by Ephemeralwaves:
[mediawiki/extensions/TemplateWizard@master] Selenium: Template insertion death date field test

Reason:
fragile test

https://gerrit.wikimedia.org/r/626479

zeljkofilipin edited projects, added Quality-and-Test-Engineering-Team; removed User-zeljkofilipin.May 6 2021, 3:51 PM
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.
Ephemeralwaves updated the task description. (Show Details)Jun 28 2021, 8:08 PM
Reedy renamed this task from Refactor TemplateWizard Selenium tests to Refactor TemplateWizard Selenium tests.Jun 28 2021, 8:44 PM
MusikAnimal removed a project: Community-Tech.Jul 28 2021, 12:27 AM
gerritbot added a comment.Sep 17 2021, 9:44 AM

Change 626458 abandoned by Zfilipin:

[mediawiki/extensions/TemplateWizard@master] Selenium: Template insertion dialog error test

Reason:

Looks like the team in charge of the repository isn't interested in the refactoring.

https://gerrit.wikimedia.org/r/626458

zeljkofilipin closed this task as Resolved.Sep 17 2021, 9:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits