Page MenuHomePhabricator
Create Task
Maniphest T240781

Special:CheckUserLog should make IPs a link to contribs
Closed, ResolvedPublic
Actions

Description

If you open Special:CheckUserLog, you'll find that while usernames are linked to their contribs, IPs are not. Let's fix it!

image.png (67×833 px, 20 KB)

After my change, it'll look like this:

image.png (636×852 px, 250 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CheckUserLog: Make IPs linksmediawiki/extensions/CheckUsermaster+2 -6
Customize query in gerrit

Event Timeline

Urbanecm created this task.Dec 15 2019, 10:11 AM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptDec 15 2019, 10:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 15 2019, 10:20 AM

Change 557500 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/CheckUser@master] CheckUserLog: Make IPs links

https://gerrit.wikimedia.org/r/557500

gerritbot added a project: Patch-For-Review.Dec 15 2019, 10:20 AM
Urbanecm moved this task from Inbox to Patches for review on the CheckUser board.Dec 15 2019, 10:20 AM
Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.
MER-C added a project: Anti-Harassment-Team.Dec 15 2019, 11:01 AM
MER-C subscribed.

Punting to Anti-Harassment for review.

Restricted Application added a subscriber: MGChecker. · View Herald TranscriptDec 15 2019, 11:01 AM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Dec 17 2019, 9:25 PM
Niharika subscribed.Dec 17 2019, 9:28 PM

@Urbanecm Can you add a screenshot of the change in the task description? Including how this will work for IP ranges, if at all.

Urbanecm added a comment.EditedDec 17 2019, 9:52 PM

Yes @Niharika. Looks like this:

image.png (636×852 px, 250 KB)

Prior my change:

image.png (419×894 px, 158 KB)

Urbanecm updated the task description. (Show Details)Dec 17 2019, 9:53 PM
Niharika added a comment.Dec 17 2019, 10:03 PM

Thanks @Urbanecm? Does the IP link lead to the IP's contribs? What about the range link?

Tchanders subscribed.Dec 18 2019, 12:00 AM

@Niharika The links are as follows:

  • IP link - Special:Contributions page for that IP
  • IP range link - Special:Contributions page for that IP range
  • Username link - user page (contributions are linked to from the "contribs" link at the end of the row)
Urbanecm added a comment.Dec 18 2019, 7:58 AM

As @Tchanders says.

Niharika added a comment.Dec 18 2019, 10:49 PM
In T240781#5749679, @Tchanders wrote:

@Niharika The links are as follows:

  • IP link - Special:Contributions page for that IP
  • IP range link - Special:Contributions page for that IP range
  • Username link - user page (contributions are linked to from the "contribs" link at the end of the row)

Cool. That all sounds good to me.

gerritbot added a comment.Dec 19 2019, 1:02 PM

Change 557500 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] CheckUserLog: Make IPs links

https://gerrit.wikimedia.org/r/557500

Urbanecm closed this task as Resolved.Dec 19 2019, 1:03 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 19 2019, 1:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 19 2019, 2:00 PM
• Dreamy_Jazz moved this task from Patches for review to Inbox on the CheckUser board.Jan 29 2024, 9:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits