Page MenuHomePhabricator

Disabled TagMultiSelectWidget has missized and misaligned "X" on tags with Apex theme
Closed, ResolvedPublic

Description

To reproduce

  1. Open the Demos page
  2. Select Apex theme (WikimediaUI works correctly)
  3. Scroll down to the "TagMultiSelect" section
  4. Enter some tags into the first widget
  5. Open the "show code" and enter widget.setDisabled( true ) in the console there.

Expected result

Either the "X" icons remain sized and positioned as they were before step 5, or they disappear entirely like in the WikimediaUI theme.

Actual result

ooui-TagMultiSelectWidget-disabled.png (157×841 px, 15 KB)

Event Timeline

Change 668489 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Apex: Hide close button on disabled tagItemWidget

https://gerrit.wikimedia.org/r/668489

Change 668489 merged by jenkins-bot:
[oojs/ui@master] Apex: Hide close button on disabled tagItemWidget

https://gerrit.wikimedia.org/r/668489

Change 670240 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.41.2

https://gerrit.wikimedia.org/r/670240

Change 670240 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.41.2

https://gerrit.wikimedia.org/r/670240

Volker_E triaged this task as Low priority.
Volker_E edited projects, added OOUI (OOUI-0.41.2); removed OOUI.