Disabled TagMultiSelectWidget has missized and misaligned "X" on tags with Apex theme
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Dec 16 2019, 2:53 PM

Description

To reproduce

Open the Demos page
Select Apex theme (WikimediaUI works correctly)
Scroll down to the "TagMultiSelect" section
Enter some tags into the first widget
Open the "show code" and enter widget.setDisabled( true ) in the console there.

Expected result

Either the "X" icons remain sized and positioned as they were before step 5, or they disappear entirely like in the WikimediaUI theme.

Actual result

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.41.2	mediawiki/core	master	+147 -162
	Apex: Hide close button on disabled tagItemWidget	oojs/ui	master	+5 -0

Mentioned In: T252283: [Mute Prefs] [MonoBook skin] Do not display the "X" removal sign on globally muted users on Special:Preferences
T269829: TagMultiSelectWidget misaligned "x" in tags

Change 668489 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Apex: Hide close button on disabled tagItemWidget

Change 668489 merged by jenkins-bot:
[oojs/ui@master] Apex: Hide close button on disabled tagItemWidget

Change 670240 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.41.2

Change 670240 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.41.2

matmarex closed this task as Resolved.Mar 9 2021, 9:51 PM

Volker_E triaged this task as Low priority.

Volker_E edited projects, added OOUI (OOUI-0.41.2); removed OOUI.

	F31477823: ooui-TagMultiSelectWidget-disabled.png
	Dec 16 2019, 2:53 PM