Page MenuHomePhabricator

The "afl_change_deleted_patrolled" database patch is not applied by onLoadExtensionSchemaUpdates.
Closed, ResolvedPublic

Description

The db_patches/patch-afl_change_deleted_patrolled.sql database patch is not applied by onLoadExtensionSchemaUpdates resulting in existing log entries for Special:AbuseFilterLog to disappear for regular users.

This breaks on all MW 1.33 installations due this change with the AbuseFilter release for MW 1.33.

Related change where this bug was introduced: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/AbuseFilter/+/01f699ff07433ed97cbba530d999b8e794fe976e
Database patch introduced here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/AbuseFilter/+/1ee749a966714a1c82d45520e7a025c847a3ed86

In includes/pagers/AbuseLogPager.php:

		if ( !$this->mForm->canSeeHidden() ) {
			$info['conds']['afl_deleted'] = 0;
		}
MySQL [dota2_gamepedia]> select * from abuse_filter_log where afl_deleted = 0;
Empty set (0.229 sec)

MySQL [dota2_gamepedia]> select afl_deleted from abuse_filter_log group by afl_deleted; 
+-------------+
| afl_deleted |
+-------------+
|        NULL |
+-------------+
1 row in set (0.104 sec)

Event Timeline

Change 558199 had a related patch set uploaded (by Alexia; owner: Alexia):
[mediawiki/extensions/AbuseFilter@master] Actually apply patch-afl_change_deleted_patrolled.

https://gerrit.wikimedia.org/r/558199

I'll make sure to prepare the (painful) backports for 1.33 and 1.34 as well, once the patch is reviewed/approved/merged on master.

Change 627959 had a related patch set uploaded (by Daimona Eaytoy; owner: Alexia):
[mediawiki/extensions/AbuseFilter@REL1_35] Actually apply patch-afl_change_deleted_patrolled.

https://gerrit.wikimedia.org/r/627959

Change 627960 had a related patch set uploaded (by Daimona Eaytoy; owner: Alexia):
[mediawiki/extensions/AbuseFilter@REL1_34] Actually apply patch-afl_change_deleted_patrolled.

https://gerrit.wikimedia.org/r/627960

Change 558199 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Actually apply patch-afl_change_deleted_patrolled.

https://gerrit.wikimedia.org/r/558199

Change 627959 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@REL1_35] Actually apply patch-afl_change_deleted_patrolled.

https://gerrit.wikimedia.org/r/627959

Change 627960 abandoned by Daimona Eaytoy:
[mediawiki/extensions/AbuseFilter@REL1_34] Actually apply patch-afl_change_deleted_patrolled.

Reason:
Meh, 1.34 is EOL next month anyway, I don't expect anyone upgrading to 1.34 and having issues right now.

https://gerrit.wikimedia.org/r/627960