Page MenuHomePhabricator
Create Task
Maniphest T240924

Special:NewPages - Exception caught inside exception handler when filtering using associated namespace
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error message
MediaWiki internal error.

Original exception: [XfhsPQpAADwAAJ22fjYAAAAN] 2019-12-17 05:48:45: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Exception caught inside exception handler.

Set $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information.
Impact
Notes

Trying to use filtering of registered users following T238483: Special:NewPages - allow hiding pages created by users when non-users can create talk pages
Can be reproduced by following the same link - consistently returns an error
A bit of testing reveals that there is generally an error when attempting to use associated namespaces (eg https://en.wikipedia.org/wiki/Special:NewPages?namespace=2&invert=&associated=1&limit=100)

Details

Request ID
XfhsPQpAADwAAJ22fjYAAAAN
Request URL
https://en.wikipedia.org/wiki/Special:NewPages?namespace=2&invert=1&associated=1&tagfilter=&username=&size-mode=max&size=10&wpFormIdentifier=newpagesform&limit=100
Stack Trace
#0 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1159): Wikimedia\Rdbms\Database->assertQueryIsCurrentlyAllowed(string, string)
#1 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1828): Wikimedia\Rdbms\Database->query(string, string)
#2 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1920): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
#3 /srv/mediawiki/php-master/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectRow(string, array, array, string)
#4 /srv/mediawiki/php-master/includes/libs/rdbms/database/DBConnRef.php(336): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /srv/mediawiki/php-master/includes/cache/LinkCache.php(331): Wikimedia\Rdbms\DBConnRef->selectRow(string, array, array, string)
#6 /srv/mediawiki/php-master/includes/cache/LinkCache.php(280): LinkCache->fetchPageRow(Wikimedia\Rdbms\MaintainableDBConnRef, Title)
#7 /srv/mediawiki/php-master/includes/Title.php(3177): LinkCache->addLinkObj(Title)
#8 /srv/mediawiki/php-master/includes/Title.php(4133): Title->getArticleID(integer)
#9 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HelpPanel.php(120): Title->exists()
#10 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HelpPanelHooks.php(83): GrowthExperiments\HelpPanel::shouldShowHelpPanel(OutputPage)
#11 /srv/mediawiki/php-master/includes/Hooks.php(174): GrowthExperiments\HelpPanelHooks::onBeforePageDisplay(OutputPage, SkinVector)
#12 /srv/mediawiki/php-master/includes/Hooks.php(234): Hooks::callHook(string, array, array, NULL, string)
#13 /srv/mediawiki/php-master/includes/OutputPage.php(2623): Hooks::runWithoutAbort(string, array)
#14 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(150): OutputPage->output()
#15 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(64): MWExceptionRenderer::reportHTML(Wikimedia\Rdbms\DBQueryError)
#16 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(103): MWExceptionRenderer::output(Wikimedia\Rdbms\DBQueryError, integer)
#17 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(177): MWExceptionHandler::report(Wikimedia\Rdbms\DBQueryError)
#18 /srv/mediawiki/php-master/includes/MediaWiki.php(563): MWExceptionHandler::handleException(Wikimedia\Rdbms\DBQueryError)
#19 /srv/mediawiki/php-master/index.php(46): MediaWiki->run()
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}
SubjectRepoBranchLines +/-
NewPagesPager: Fix namespace query conditionsmediawiki/corewmf/1.35.0-wmf.10+7 -4
NewPagesPager: Fix namespace query conditionsmediawiki/coreREL1_34+7 -4
NewPagesPager: Fix namespace query conditionsmediawiki/corewmf/1.35.0-wmf.11+7 -4
NewPagesPager: Fix namespace query conditionsmediawiki/coremaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Dec 17 2019, 5:54 AM
Restricted Application added projects: User-DannyS712, Platform Engineering. · View Herald TranscriptDec 17 2019, 5:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 renamed this task from Exception caught inside exception handler. to Special:NewPages - Exception caught inside exception handler.when filtering using associated namespace.Dec 17 2019, 5:54 AM
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)
DannyS712 renamed this task from Special:NewPages - Exception caught inside exception handler.when filtering using associated namespace to Special:NewPages - Exception caught inside exception handler when filtering using associated namespace.Dec 17 2019, 5:57 AM
DannyS712 added a project: Beta-Cluster-reproducible.Dec 17 2019, 6:02 AM

https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPages?namespace=0&invert=1&associated=1&tagfilter=&username=&size-mode=min&size=&wpFormIdentifier=newpagesform&limit=100 reveals:

MediaWiki internal error.

Original exception: [XfhulKwQBHcAAETGpvgAAABT] /wiki/Special:NewPages?namespace=0&invert=1&associated=1&tagfilter=&username=&size-mode=min&size=&wpFormIdentifier=newpagesform&limit=100 Wikimedia\Rdbms\DBQueryError from line 1626 of /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
Query: SELECT rc_id,rc_timestamp,rc_namespace,rc_title,rc_minor,rc_bot,rc_new,rc_cur_id,rc_this_oldid,rc_last_oldid,rc_type,rc_source,rc_patrolled,rc_ip,rc_old_len,rc_new_len,rc_deleted,rc_logid,rc_log_type,rc_log_action,rc_params,comment_rc_comment.comment_text AS `rc_comment_text`,comment_rc_comment.comment_data AS `rc_comment_data`,comment_rc_comment.comment_id AS `rc_comment_cid`,actor_rc_user.actor_user AS `rc_user`,actor_rc_user.actor_name AS `rc_user_text`,rc_actor,page_len AS `length`,page_latest AS `rev_id`,page_namespace,page_title,fp_stable,fp_pending_since,(SELECT GROUP_CONCAT(ctd_name SEPARATOR ',') FROM `change_tag` JOIN `change_tag_def` ON ((ct_tag_id=ctd_id)) WHERE ct_rc_id=rc_id ) AS `ts_tags` FROM `recentchanges` JOIN `comment` `comment_rc_comment` ON ((comment_rc_comment.comment_id = rc_comment_id)) JOIN `actor` `actor_rc_user` ON ((actor_rc_user.actor_id = rc_actor)) JOIN `page` ON ((page_id=rc_cur_id)) LEFT JOIN `flaggedpages` ON ((fp_page_id = rc_cur_id)) WHERE rc_new = 1 AND (rc_namespace != 0AND rc_namespace != 1) AND page_is_redirect = 0 ORDER BY rc_timestamp DESC LIMIT 101
Function: IndexPager::buildQueryInfo (NewPagesPager)
Error: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rc_namespace != 1) AND page_is_redirect = 0 ORDER BY rc_timestamp DESC LIMIT 10' at line 1 (172.16.4.147:3306)
Backtrace:
#0 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1610): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
#1 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1587): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#2 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1166): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#3 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1828): Wikimedia\Rdbms\Database->query(string, string)
#4 /srv/mediawiki/php-master/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#5 /srv/mediawiki/php-master/includes/libs/rdbms/database/DBConnRef.php(318): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#6 /srv/mediawiki/php-master/includes/pager/IndexPager.php(425): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#7 /srv/mediawiki/php-master/includes/pager/IndexPager.php(270): IndexPager->reallyDoQuery(string, integer, boolean)
#8 /srv/mediawiki/php-master/includes/pager/IndexPager.php(616): IndexPager->doQuery()
#9 /srv/mediawiki/php-master/includes/specials/SpecialNewpages.php(162): IndexPager->getNumRows()
#10 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(575): SpecialNewpages->execute(NULL)
#11 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run(NULL)
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(967): MediaWiki->performRequest()
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(530): MediaWiki->main()
#15 /srv/mediawiki/php-master/index.php(46): MediaWiki->run()
#16 /srv/mediawiki/w/index.php(3): require(string)
#17 {main}
Exception caught inside exception handler: [XfhulKwQBHcAAETGpvgAAABT] /wiki/Special:NewPages?namespace=0&invert=1&associated=1&tagfilter=&username=&size-mode=min&size=&wpFormIdentifier=newpagesform&limit=100 Wikimedia\Rdbms\DBTransactionStateError from line 1433 of /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php: Cannot execute query from LinkCache::fetchPageRow while transaction status is ERROR
Backtrace:
#0 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1159): Wikimedia\Rdbms\Database->assertQueryIsCurrentlyAllowed(string, string)
#1 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1828): Wikimedia\Rdbms\Database->query(string, string)
#2 /srv/mediawiki/php-master/includes/libs/rdbms/database/Database.php(1920): Wikimedia\Rdbms\Database->select(string, array, array, string, array, array)
#3 /srv/mediawiki/php-master/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->selectRow(string, array, array, string)
#4 /srv/mediawiki/php-master/includes/libs/rdbms/database/DBConnRef.php(336): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /srv/mediawiki/php-master/includes/cache/LinkCache.php(331): Wikimedia\Rdbms\DBConnRef->selectRow(string, array, array, string)
#6 /srv/mediawiki/php-master/includes/cache/LinkCache.php(280): LinkCache->fetchPageRow(Wikimedia\Rdbms\MaintainableDBConnRef, Title)
#7 /srv/mediawiki/php-master/includes/Title.php(3177): LinkCache->addLinkObj(Title)
#8 /srv/mediawiki/php-master/includes/Title.php(4133): Title->getArticleID(integer)
#9 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HelpPanel.php(120): Title->exists()
#10 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/HelpPanelHooks.php(83): GrowthExperiments\HelpPanel::shouldShowHelpPanel(OutputPage)
#11 /srv/mediawiki/php-master/includes/Hooks.php(174): GrowthExperiments\HelpPanelHooks::onBeforePageDisplay(OutputPage, SkinVector)
#12 /srv/mediawiki/php-master/includes/Hooks.php(234): Hooks::callHook(string, array, array, NULL, string)
#13 /srv/mediawiki/php-master/includes/OutputPage.php(2623): Hooks::runWithoutAbort(string, array)
#14 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(150): OutputPage->output()
#15 /srv/mediawiki/php-master/includes/exception/MWExceptionRenderer.php(64): MWExceptionRenderer::reportHTML(Wikimedia\Rdbms\DBQueryError)
#16 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(103): MWExceptionRenderer::output(Wikimedia\Rdbms\DBQueryError, integer)
#17 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(177): MWExceptionHandler::report(Wikimedia\Rdbms\DBQueryError)
#18 /srv/mediawiki/php-master/includes/MediaWiki.php(563): MWExceptionHandler::handleException(Wikimedia\Rdbms\DBQueryError)
#19 /srv/mediawiki/php-master/index.php(46): MediaWiki->run()
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}

There appear to be two different issues here - the sql error, and the exception handler's failure to handle it

DannyS712 claimed this task.Dec 17 2019, 6:22 AM
gerritbot added a comment.Dec 17 2019, 6:23 AM

Change 558328 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] NewPagesPager: Fix namespace query conditions

https://gerrit.wikimedia.org/r/558328

gerritbot added a project: Patch-For-Review.Dec 17 2019, 6:23 AM
DannyS712 moved this task from Untriaged to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.Dec 17 2019, 6:27 AM

Caused by (me) omitting a needed space in T47133: Add talk namespace option to Special:NewPages

DannyS712 moved this task from Mar 2019 / 1.33wmf20-23 to Aug2019/1.34.wmf.17+ on the Wikimedia-production-error board.Dec 17 2019, 6:28 AM
Aklapper edited Stack Trace. (Show Details)Dec 17 2019, 9:19 AM
gerritbot added a comment.Dec 17 2019, 1:44 PM

Change 558328 merged by jenkins-bot:
[mediawiki/core@master] NewPagesPager: Fix namespace query conditions

https://gerrit.wikimedia.org/r/558328

gerritbot added a comment.Dec 17 2019, 1:58 PM

Change 558519 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.11] NewPagesPager: Fix namespace query conditions

https://gerrit.wikimedia.org/r/558519

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 17 2019, 2:00 PM
Anomie removed a project: Platform Engineering.Dec 17 2019, 2:04 PM
gerritbot added a comment.Dec 17 2019, 3:48 PM

Change 558559 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/core@wmf/1.35.0-wmf.10] NewPagesPager: Fix namespace query conditions

https://gerrit.wikimedia.org/r/558559

gerritbot added a comment.Dec 17 2019, 3:50 PM

Change 558562 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/core@REL1_34] NewPagesPager: Fix namespace query conditions

https://gerrit.wikimedia.org/r/558562

gerritbot added a comment.Dec 17 2019, 3:59 PM

Change 558562 merged by jenkins-bot:
[mediawiki/core@REL1_34] NewPagesPager: Fix namespace query conditions

https://gerrit.wikimedia.org/r/558562

ReleaseTaggerBot added a project: MW-1.34-notes.Dec 17 2019, 4:00 PM
gerritbot added a comment.Dec 17 2019, 4:00 PM

Change 558519 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.11] NewPagesPager: Fix namespace query conditions

https://gerrit.wikimedia.org/r/558519

gerritbot added a comment.Dec 17 2019, 4:04 PM

Change 558559 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.10] NewPagesPager: Fix namespace query conditions

https://gerrit.wikimedia.org/r/558559

Stashbot added a comment.Dec 17 2019, 4:07 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-17T16:07:24Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.11/includes/specials/pagers/NewPagesPager.php: T240924 NewPagesPager: Fix namespace query conditions (duration: 01m 02s)

Maintenance_bot removed a project: Patch-For-Review.Dec 17 2019, 4:10 PM
Stashbot added a comment.Dec 17 2019, 4:14 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-17T16:14:10Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.10/includes/specials/pagers/NewPagesPager.php: T240924 NewPagesPager: Fix namespace query conditions (duration: 01m 03s)

Jdforrester-WMF closed this task as Resolved.Dec 17 2019, 4:15 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF subscribed.

Thank you!

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.10; 2019-12-10); removed MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 17 2019, 5:00 PM
DannyS712 added a comment.Dec 17 2019, 5:11 PM

@Jdforrester-WMF should this be added to the release notes for 1.34 (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/558562/) given that it was backported?

Jdforrester-WMF added a comment.Dec 18 2019, 11:02 AM
In T240924#5748337, @DannyS712 wrote:

@Jdforrester-WMF should this be added to the release notes for 1.34 (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/558562/) given that it was backported?

As we're about to do the release, I'll do a last-minute tune-up of the release notes, including this.

Jdforrester-WMF added a subscriber: Reedy.Dec 18 2019, 11:54 AM
In T240924#5750683, @Jdforrester-WMF wrote:
In T240924#5748337, @DannyS712 wrote:

@Jdforrester-WMF should this be added to the release notes for 1.34 (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/558562/) given that it was backported?

As we're about to do the release, I'll do a last-minute tune-up of the release notes, including this.

Never mind, @Reedy did it already in 3d47388b4faa7fcf4e96ba46acea7dac5c9afbf7.

DannyS712 moved this task from Aug2019/1.34.wmf.17+ to Resolved on the Wikimedia-production-error board.Dec 19 2019, 10:13 AM
DannyS712 moved this task from Reports to Merged on the User-DannyS712 board.Dec 26 2019, 6:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits