Page MenuHomePhabricator

Clean up SSL configuration
Open, MediumPublic

Description

In the process of trying to document a our SSL configuration I have come across a few inconsistencies which would be good to tidy up.

  • logstash uses base::expose_puppet_certs but doesn't seem to use the certificates
  • a number of services using tlsproxy::localssl should be migrated to profile::tlsproxy::envoy
  • Enable ssl validation for conf tool, possibly add client auth
  • abstract stunnel4 used for rsync and migrate services to it
  • possibly enable TLS verify Peer = yes on the backup servers
  • investigate moving the puppet CA out of the helm charts repo
  • migrate cassandra-ca to certgen
  • investigate/normilise puppet_ssldir() vs facts['puppet_config']['ssldir']
  • cloud instances which have there own puppet master have a value of /var/lib/puppet/client/ssl for puppet_ssldir(). used by base::certificates and base::expose_puppet::certs

Note: Audit is ongoing so this list will likely grow

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone

Event Timeline

jbond triaged this task as Medium priority.Dec 17 2019, 12:29 PM
jbond created this task.
jbond updated the task description. (Show Details)
jbond removed subscribers: Puppet, SRE.

Change 558496 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] logstash: remove base::expose_puppet_certs.

https://gerrit.wikimedia.org/r/558496

Change 558501 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] nginx::simple_tlsproxy: remove class

https://gerrit.wikimedia.org/r/558501

Change 558501 merged by Jbond:
[operations/puppet@production] nginx::simple_tlsproxy: remove class

https://gerrit.wikimedia.org/r/558501

Change 558496 merged by Jbond:
[operations/puppet@production] logstash: remove base::expose_puppet_certs.

https://gerrit.wikimedia.org/r/558496

Change 561816 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] etcd: add paramater type checking and clean up

https://gerrit.wikimedia.org/r/561816

Change 561817 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] etcd: enable ssl validation

https://gerrit.wikimedia.org/r/561817

Change 561818 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] etcd: add cert parameter to enable client auth

https://gerrit.wikimedia.org/r/561818

Change 561819 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] etcd: remove username/password

https://gerrit.wikimedia.org/r/561819

Change 561850 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] profile::tlsproxy::envoy: add type checking and defaults

https://gerrit.wikimedia.org/r/561850

Dzahn renamed this task from Clean up SSL configueration to Clean up SSL configuration.Jan 8 2020, 11:17 PM
Dzahn updated the task description. (Show Details)
Dzahn subscribed.

Change 561816 merged by Jbond:
[operations/puppet@production] etcd: add parameter type checking and clean up

https://gerrit.wikimedia.org/r/561816

Change 561817 merged by Jbond:
[operations/puppet@production] etcd: enable ssl validation

https://gerrit.wikimedia.org/r/561817

Change 566009 had a related patch set uploaded (by Jbond; owner: Jbond):
[operations/puppet@production] etcd: enable ssl validation

https://gerrit.wikimedia.org/r/566009

Change 566009 merged by Jbond:
[operations/puppet@production] etcd: enable ssl validation

https://gerrit.wikimedia.org/r/566009

Change 574009 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] profile::tlsproxy::envoy: refactor parameters

https://gerrit.wikimedia.org/r/574009

Change 574010 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] profile::tlsproxy::envoy: add support for acme certs

https://gerrit.wikimedia.org/r/574010

Change 574011 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] profile::idp: update profile to use tlsproxy::envoy

https://gerrit.wikimedia.org/r/574011

SSL validation has been turned on for conftool however client authentication will need to wait untill we migrate to ectd v3 as RBAC is not optimised in v2

Change 574011 abandoned by Jbond:
profile::idp: update profile to use tlsproxy::envoy

Reason:
chain messed up

https://gerrit.wikimedia.org/r/574011

Change 561850 merged by Jbond:
[operations/puppet@production] profile::tlsproxy::envoy: add type checking and defaults

https://gerrit.wikimedia.org/r/561850

Change 574009 merged by Jbond:
[operations/puppet@production] profile::tlsproxy::envoy: add custom SNI type

https://gerrit.wikimedia.org/r/574009

Change 574010 merged by Jbond:
[operations/puppet@production] profile::tlsproxy::envoy: add support for acme certs

https://gerrit.wikimedia.org/r/574010

Change 574020 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] profile::idp: update profile to use tlsproxy::envoy

https://gerrit.wikimedia.org/r/574020

Change 574020 merged by Jbond:
[operations/puppet@production] profile::idp: update profile to use tlsproxy::envoy

https://gerrit.wikimedia.org/r/574020

Change 581996 had a related patch set uploaded (by Jbond; owner: Jbond):
[operations/puppet@production] profile::idp: update profile to use tlsproxy::envoy

https://gerrit.wikimedia.org/r/581996

Change 581996 merged by Jbond:
[operations/puppet@production] profile::idp: update profile to use tlsproxy::envoy

https://gerrit.wikimedia.org/r/581996

Change 582786 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/dns@master] idp: failover IDP to eqiad

https://gerrit.wikimedia.org/r/582786

Change 582786 merged by Jbond:
[operations/dns@master] idp: failover IDP to eqiad

https://gerrit.wikimedia.org/r/582786

Change 561818 abandoned by Jbond:

[operations/puppet@production] etcd: add cert parameter to enable client auth

Reason:

not desired

https://gerrit.wikimedia.org/r/561818

Change 561819 abandoned by Jbond:

[operations/puppet@production] etcd: remove username/password

Reason:

not desired

https://gerrit.wikimedia.org/r/561819