Page MenuHomePhabricator
Create Task
Maniphest T240948

Create variables for site language and server name
Closed, ResolvedPublic
Actions

Description

See discussion.

Details

SubjectRepoBranchLines +/-
Add site name and language variablesmediawiki/extensions/AbuseFiltermaster+61 -1
Customize query in gerrit

Event Timeline

Daimona created this task.Dec 17 2019, 1:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2019, 1:38 PM
Daimona moved this task from Backlog to Filtering features on the AbuseFilter board.Dec 17 2019, 1:38 PM
Daimona added a project: User-Daimona.Dec 17 2019, 2:01 PM
Bugreporter closed this task as a duplicate of T97933: Create variable for project name.Dec 17 2019, 2:02 PM
Daimona added a comment.Dec 17 2019, 2:05 PM

Quick notes: the wiki name should probably be a "static" variable, but I think it would make sense to rename generateStaticVars to generateGenericVars (and also the hook and related docs). Ideally, the same should go for the language.
Also, we need to make sure that these variables will be generated when examining RC entries.

Daimona reopened this task as Open.Dec 17 2019, 3:12 PM

Hah, I was sure we had a duplicate bug! That said, I'd like to keep this bug open for the "site language" part. I think I'll submit a patch shortly.

Daimona claimed this task.Dec 17 2019, 4:01 PM
Daimona removed a project: User-Daimona.
gerritbot added a comment.Dec 17 2019, 4:49 PM

Change 558567 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Add site name and language variables

https://gerrit.wikimedia.org/r/558567

gerritbot added a project: Patch-For-Review.Dec 17 2019, 4:49 PM
Billinghurst added a project: Stewards-and-global-tools.Dec 19 2019, 1:26 PM
gerritbot added a comment.Feb 10 2020, 7:06 PM

Change 558567 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add site name and language variables

https://gerrit.wikimedia.org/r/558567

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2020, 7:10 PM
Daimona closed this task as Resolved.Feb 11 2020, 9:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL