VisualEditor throwing "PHP Notice: Undefined index: etag" on officewiki as of wmf.11
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	Jdforrester-WMF
	Dec 17 2019, 3:56 PM

Description

Error

MediaWiki version: 1.35.0-wmf.11

message

PHP Notice: Undefined index: etag

Impact

Notes

Details

Request ID: Xfj4fQpAMEMAAIOztv4AAABP
Request URL: https://office.wikimedia.org/w/api.php

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.11/extensions/VisualEditor/includes/ApiVisualEditor.php(630): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.11/includes/api/ApiMain.php(1603): ApiVisualEditor->execute()
#2 /srv/mediawiki/php-1.35.0-wmf.11/includes/api/ApiMain.php(539): ApiMain->executeAction()
#3 /srv/mediawiki/php-1.35.0-wmf.11/includes/api/ApiMain.php(510): ApiMain->executeActionWithErrorHandling()
#4 /srv/mediawiki/php-1.35.0-wmf.11/api.php(78): ApiMain->execute()
#5 /srv/mediawiki/w/api.php(3): require(string)
#6 {main}

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix unchecked array access in ApiVisualEditor	mediawiki/extensions/VisualEditor	master	+1 -1
	Fix unchecked array access in ApiVisualEditor	mediawiki/extensions/VisualEditor	wmf/1.35.0-wmf.11	+1 -1

Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Dec 17 2019, 3:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 17 2019, 3:56 PM

@matmarex, Ed blames you for this code area. ;-)

Krinkle added a parent task: T233859: 1.35.0-wmf.11 deployment blockers.Dec 17 2019, 9:07 PM

Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.

train blocker == UBN!

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptDec 17 2019, 11:22 PM

• Agusbou2015 subscribed.Dec 18 2019, 12:06 AM

Change 558863 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Fix unchecked array access in ApiVisualEditor

https://gerrit.wikimedia.org/r/558863

gerritbot added a project: Patch-For-Review.Dec 18 2019, 7:25 AM

Change 558863 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix unchecked array access in ApiVisualEditor

https://gerrit.wikimedia.org/r/558863

Change 559006 had a related patch set uploaded (by Jforrester; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.11] Fix unchecked array access in ApiVisualEditor

https://gerrit.wikimedia.org/r/559006

Change 559006 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.11] Fix unchecked array access in ApiVisualEditor

https://gerrit.wikimedia.org/r/559006

Mentioned in SAL (#wikimedia-operations) [2019-12-18T10:47:48Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.11/extensions/VisualEditor/includes/ApiVisualEditor.php: T240961: Fix unchecked array access in ApiVisualEditor (duration: 01m 02s)

Work around deployed. No longer a blocker (really, this wasn't in the first place).

Jdforrester-WMF removed a parent task: T233859: 1.35.0-wmf.11 deployment blockers.Dec 18 2019, 10:54 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 18 2019, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 18 2019, 11:10 AM

This probably only affected officewiki and other private wikis, where VisualEditor talks directly to Parsoid rather than RESTBase (and the variable name $restbaseHeaders is a bit of a misnomer). However, I thought that Parsoid also returns an ETag header on its responses. This might indicate a Parsoid bug. Your fix looks correct to me under the circumstances, thanks!

matmarex closed this task as Resolved.Jun 29 2020, 11:40 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 29 2020, 11:40 AM

VisualEditor throwing "PHP Notice: Undefined index: etag" on officewiki as of wmf.11Closed, ResolvedPublicPRODUCTION ERRORActions