Page MenuHomePhabricator
Create Task
Maniphest T240966

Fix code smells in WikibaseMediaInfoHooks.php
Closed, ResolvedPublic
Actions

Description

See https://sonarcloud.io/project/issues?id=mediawiki-extensions-WikibaseMediaInfo&open=AWtQgEnh47lEt0jjhL96&resolved=false

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix code smellsmediawiki/extensions/WikibaseMediaInfomaster+86 -77
Customize query in gerrit

Event Timeline

Cparle created this task.Dec 17 2019, 4:43 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptDec 17 2019, 4:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 17 2019, 5:13 PM

Change 558592 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix code smells

https://gerrit.wikimedia.org/r/558592

gerritbot added a project: Patch-For-Review.Dec 17 2019, 5:13 PM
gerritbot added a comment.Jan 14 2020, 2:07 PM

Change 558592 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix code smells

https://gerrit.wikimedia.org/r/558592

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2020, 2:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 14 2020, 3:00 PM
• Ramsey-WMF subscribed.Feb 27 2020, 8:52 PM

@Cparle can we close this one?

Cparle closed this task as Resolved.Feb 28 2020, 9:37 AM
Cparle claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits