Page MenuHomePhabricator
Create Task
Maniphest T240983

Don't allow payment intervals for specific payment types
Closed, ResolvedPublic
Actions

Description

Recurring donations are (technically) not possible when using "Sofort". In laika (and 10h16), there is no logic to prevent this.

Acceptance Criteria

  • When selecting any payment interval other than "one-time", the payment type "Sofortüberweisung" is disabled.
  • When choosing one-time donation, the payment type "Sofortüberweisung" is enabled.
  • When choosing the payment type "Sofortüberweisung", all payment intervals other than "one-time" are disabled.
  • When choosing any other payment type, all payment intervals are enabled.
  • Checked options that are disabled are being unchecked.
  • When the payment type "Sofortüberweisung" is disabled, it shows an additional notice about the reason.

Mocks

Payment interval options disabled when "Sofort-Überweisung" is selected
screenshot-spenden.wikimedia.de-2019.12.17-19-38-42.png (409×366 px, 23 KB)
Payment type option "Sofort-Überweisung" disabled when payment interval is selected
screenshot-spenden.wikimedia.de-2019.12.17-19-33-27.png (73×360 px, 6 KB)

Event Timeline

kai.nissen created this task.Dec 17 2019, 6:42 PM
Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptDec 17 2019, 6:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
tmletzko subscribed.Dec 18 2019, 10:46 AM

according to vewa there are 195 cases of recurrent SUB payments (79 in 2017, 68 in 2018 and 47 in 2019). Can you confirm this number?

CorinnaHillebrand_WMDE claimed this task.Dec 18 2019, 2:49 PM
CorinnaHillebrand_WMDE moved this task from Heap to Doing on the WMDE-FUN-Funban-2019 board.
kai.nissen added a comment.Dec 18 2019, 5:02 PM

@tmletzko I can only find 47 data sets for 2017, the numbers for 2018 and 2019 exactly match.

CorinnaHillebrand_WMDE removed CorinnaHillebrand_WMDE as the assignee of this task.Dec 19 2019, 10:55 AM
CorinnaHillebrand_WMDE moved this task from Doing to Code Review on the WMDE-FUN-Funban-2019 board.
CorinnaHillebrand_WMDE subscribed.
gabriel-wmde moved this task from Code Review to Done on the WMDE-FUN-Funban-2019 board.Jan 2 2020, 3:12 PM
kai.nissen closed this task as Resolved.Jan 9 2020, 5:45 PM
kai.nissen claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL