Page MenuHomePhabricator

sections menu doesn't take into account section I'm currently reading
Closed, ResolvedPublicBUG REPORT

Description

1- click "sections" bottom bar button
2- chose an item that's not the first on the list (6th on the list)
3- click "sections" bottom bar button
here the cursor goes to the top of the list instead of going to the section I'm currently reading

BONUS:
It would also be nice to have the first item in the TOC be the article title to go back to the beginning of the article.

Related Objects

Event Timeline

Jpita edited projects, added Inuka-Team (Kanban); removed Inuka-Team.
Jpita moved this task from QA to Backlog on the Inuka-Team (Kanban) board.

@hueitan this is still not working, if you don't understand the expected behaviour feel free to reach out for more details.
Updating steps with new button:

0 - open http://127.0.0.1:8080/#/article/en/Portugal
1- SELECT "Sections"
2- Scroll down to Geography and SELECT
3- Menu button
4-SELECT Sections
here the cursor goes to the top of the list (Portugal) instead of going to the section I'm currently reading (Geography)

I think you are testing master branch code, the code is still on reviewed with branch https://github.com/hueitan/wikipedia-kaios/tree/toc-selected

yes, I checked your branch now and it is ok.
we need to discuss with @SBisson the right flow for us:
Dev->CR->Merge PR->QA in master
OR
Dev->CR->QA->Merge PR->QA in master.

I prefer the last one, it's easier to catch bugs before they are merged so we avoid issues on master.
For small PRs and technical PRs there's no need to wait for QA to merge, this avoids bottleneck on QA end.