Page MenuHomePhabricator

Argument 3 passed to MediaWiki\Extension\WikimediaEditorTasks\WikipediaAppDescriptionEditCounter::onRevert() must be an instance of MediaWiki\Revision\RevisionRecord, instance of Revision given, called in /srv/mediawiki/php-1.35.0-wmf.10/extensions/WikimediaEditorTasks/src/Hooks.php on line 116
Closed, ResolvedPublicBUG REPORT

Description

#0 /srv/mediawiki/php-1.35.0-wmf.10/extensions/WikimediaEditorTasks/src/Hooks.php(116): MediaWiki\Extension\WikimediaEditorTasks\WikipediaAppDescriptionEditCounter->onRevert(37716233, 291854152, Object(Revision))
#1 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/AutoCommitUpdate.php(46): MediaWiki\Extension\WikimediaEditorTasks\Hooks::MediaWiki\Extension\WikimediaEditorTasks\{closure}(Object(Wikimedia\Rdbms\DBConnRef), 'MediaWiki\\Exten...')
#2 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/DeferredUpdates.php(416): AutoCommitUpdate->doUpdate()
#3 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/DeferredUpdates.php(296): DeferredUpdates::attemptUpdate(Object(AutoCommitUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti))
#4 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/DeferredUpdates.php(233): DeferredUpdates::run(Object(AutoCommitUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti), Object(Monolog\Logger), Object(BufferingStatsdDataFactory), 'get')
#5 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/DeferredUpdates.php(150): DeferredUpdates::handleUpdateQueue(Array, 'run', 2)
#6 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(1053): DeferredUpdates::doUpdates('run')
#7 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(833): MediaWiki->restInPeace()
#8 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(842): MediaWiki->{closure}()
#9 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(569): MediaWiki->doPostOutputShutdown()
#10 /srv/mediawiki/php-1.35.0-wmf.10/index.php(46): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require('/srv/mediawiki/...')
#12 {main}

Event Timeline

Change 559623 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/WikimediaEditorTasks@master] Pass RevisionRecord to onRevert

https://gerrit.wikimedia.org/r/559623

Change 559632 had a related patch set uploaded (by Mholloway; owner: MSantos):
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.35.0-wmf.11] Pass RevisionRecord to onRevert

https://gerrit.wikimedia.org/r/559632

Change 559632 merged by Mholloway:
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.35.0-wmf.11] Pass RevisionRecord to onRevert

https://gerrit.wikimedia.org/r/559632

Mentioned in SAL (#wikimedia-operations) [2019-12-20T00:05:48Z] <mholloway-shell@deploy1001> Synchronized php-1.35.0-wmf.11/extensions/WikimediaEditorTasks: Fix: Pass a RevisionRecord to Counter::onRevert from onArticleRollbackComplete (T241013) (duration: 00m 54s)

Change 559623 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEditorTasks@master] Pass RevisionRecord to onRevert

https://gerrit.wikimedia.org/r/559623