Page MenuHomePhabricator
Create Task
Maniphest T241014

Argument 2 passed to MediaWiki\Extension\WikimediaEditorTasks\Hooks::countersOnEditSuccess() must be an instance of MediaWiki\Revision\RevisionRecord, null given, called in /srv/mediawiki/php-1.35.0-wmf.10/extensions/WikimediaEditorTasks/src/Hooks.php on line 78
Closed, ResolvedPublicBUG REPORT
Actions

Description

#0 /srv/mediawiki/php-1.35.0-wmf.10/extensions/WikimediaEditorTasks/src/Hooks.php(78): MediaWiki\Extension\WikimediaEditorTasks\Hooks::countersOnEditSuccess(Object(User), NULL)
#1 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/AutoCommitUpdate.php(46): MediaWiki\Extension\WikimediaEditorTasks\Hooks::MediaWiki\Extension\WikimediaEditorTasks\{closure}(Object(Wikimedia\Rdbms\DBConnRef), 'MediaWiki\\Exten...')
#2 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/DeferredUpdates.php(416): AutoCommitUpdate->doUpdate()
#3 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/DeferredUpdates.php(296): DeferredUpdates::attemptUpdate(Object(AutoCommitUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti))
#4 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/DeferredUpdates.php(233): DeferredUpdates::run(Object(AutoCommitUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti), Object(Monolog\Logger), Object(BufferingStatsdDataFactory), 'post')
#5 /srv/mediawiki/php-1.35.0-wmf.10/includes/deferred/DeferredUpdates.php(150): DeferredUpdates::handleUpdateQueue(Array, 'run', 2)
#6 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(1053): DeferredUpdates::doUpdates('run')
#7 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(833): MediaWiki->restInPeace()
#8 /srv/mediawiki/php-1.35.0-wmf.10/includes/MediaWiki.php(842): MediaWiki->{closure}()
#9 /srv/mediawiki/php-1.35.0-wmf.10/api.php(113): MediaWiki->doPostOutputShutdown()
#10 /srv/mediawiki/w/api.php(3): require('/srv/mediawiki/...')
#11 {main}

Details

SubjectRepoBranchLines +/-
Get revision record from revision objectmediawiki/extensions/WikimediaEditorTaskswmf/1.35.0-wmf.11+1 -5
Get revision record from revision objectmediawiki/extensions/WikimediaEditorTasksmaster+1 -5
Customize query in gerrit

Related Objects

Event Timeline

• Mholloway created this task.Dec 18 2019, 12:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2019, 12:17 AM
• Mholloway triaged this task as High priority.Dec 18 2019, 12:17 AM
• Mholloway updated the task description. (Show Details)
Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Dec 20 2019, 12:17 AM
gerritbot added a comment.Dec 20 2019, 4:06 PM

Change 559894 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/WikimediaEditorTasks@master] Check for null RevRec in onPageContentSaveComplete

https://gerrit.wikimedia.org/r/559894

gerritbot added a project: Patch-For-Review.Dec 20 2019, 4:06 PM
MSantos claimed this task.Dec 20 2019, 4:07 PM
MSantos moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
gerritbot added a comment.Dec 20 2019, 5:48 PM

Change 559894 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEditorTasks@master] Get revision record from revision object

https://gerrit.wikimedia.org/r/559894

MSantos mentioned this in rEWETe3fef3c99fb8: Get revision record from revision object.Dec 20 2019, 5:50 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 20 2019, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 20 2019, 6:10 PM
gerritbot added a comment.Dec 20 2019, 6:34 PM

Change 559931 had a related patch set uploaded (by Mholloway; owner: MSantos):
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.35.0-wmf.11] Get revision record from revision object

https://gerrit.wikimedia.org/r/559931

gerritbot added a project: Patch-For-Review.Dec 20 2019, 6:34 PM
gerritbot added a comment.Dec 20 2019, 6:38 PM

Change 559931 merged by Mholloway:
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.35.0-wmf.11] Get revision record from revision object

https://gerrit.wikimedia.org/r/559931

• Mholloway mentioned this in rEWET0d11eabc34e4: Get revision record from revision object.Dec 20 2019, 6:38 PM
Stashbot added a comment.Dec 20 2019, 6:44 PM

Mentioned in SAL (#wikimedia-operations) [2019-12-20T18:44:51Z] <mholloway-shell@deploy1001> Synchronized php-1.35.0-wmf.11/extensions/WikimediaEditorTasks: Fix: Get RevisionRecord directly from the Revision in onPageContentSaveComplete (T241014) (duration: 00m 54s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.11; 2019-12-17); removed MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 20 2019, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 20 2019, 7:10 PM
• Mholloway closed this task as Resolved.Dec 20 2019, 7:35 PM
• Mholloway moved this task from Code Review to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL