Page MenuHomePhabricator

Port sub-referencing parser tests over to Parsoid
Closed, DeclinedPublic

Description

Parsoid includes a copy of citeParserTests.txt, which we should update with new tests, also copying citeSmokeTests.txt and bookReferencing.txt. The extends attribute won't be supported yet, so write passing tests documented with TODOs where functionality is missing.

Event Timeline

The tests should not be different at all. Parsoid codebase has a syncing feature for copying tests to/from the canonical versions.

However, there is a blacklisting feature for failing tests which is how you handle known failures. Check php bin/parserTests.php --help

The tests should not be different at all. Parsoid codebase has a syncing feature for copying tests to/from the canonical versions.

Check tools/sync-parserTests.js and tools/fetch-parserTests.txt.js

We had to do a citeParserTests sync today for the changes to "<ref> defined in <references> error conditions"

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/559204

ssastry triaged this task as Medium priority.Mar 24 2020, 4:34 AM
WMDE-Fisch renamed this task from Port Book Referencing parser tests over to Parsoid to Port sub-referencing parser tests over to Parsoid.Jul 10 2024, 1:10 PM
ABreault-WMF subscribed.

In T354215, Parsoid's Cite implementention and copy of citeParserTests.txt was moved to the Cite repository.