Page MenuHomePhabricator

WWT: Handle hidden edit summaries in revision details pop-up [small]
Open, Needs TriagePublicBUG REPORT

Description

As a WWT user, I want the revision details pop-up to load with no hidden edit summary bugs, so that I can easily access the pop-up and be informed when the edit summary is hidden.

Acceptance Criteria:

  • If a revision has a hidden edit summary, the revision details pop-up should properly load without issues
  • The hidden edit summary should be displayed according to MediaWiki standards: "(edit summary removed)"

Visual Examples:

What is the problem?
When WWT shows a revision popup for a revision whose edit summary is hidden, it shows the loading animation indefinitely and no revision information will show.

It should probably handle it similarly to hidden contributor names (as implemented in T232215).

Instead of the edit summary, it could show something like: "(edit summary removed)" instead.

Steps to reproduce problem

  1. https://es.wikipedia.org/wiki/Hispanidad?oldid=100161751
  2. Launch WWT
  3. In the first paragraph, click any word in the sentence starting "Para muchos es...".

Expected behavior: Revision popup displays all information apart from the hidden edit summary.
Observed behavior: Revision popup loading animation displays indefinitely.

Environment
I have reproduce this in WWT version 0.11. Probably existed earlier.

It existed before the work in T240707, but the bug has a bigger impact after that work, as now none of the information in the revision popup will show.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 18 2019, 1:46 PM
dom_walden updated the task description. (Show Details)Dec 18 2019, 2:00 PM

This is my fault, I think. Before hidden summaries were treated as if there's no summary at all, that part I broke. Dom makes a good point though, showing "(edit summary removed)" would be consistent with MediaWiki. Or we can go back to what we had before. Thoughts, @ifried ?

We've discussed this as a team, and we should follow MediaWiki standards for displaying hidden edit summaries: "(edit summary removed)"

ifried updated the task description. (Show Details)Thu, Jan 2, 9:52 PM
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)
ifried updated the task description. (Show Details)Thu, Jan 2, 9:55 PM
ifried renamed this task from WWT: Handle hidden edit summaries to WWT: Handle hidden edit summaries in revision details pop-up.Mon, Jan 6, 11:00 PM
ifried renamed this task from WWT: Handle hidden edit summaries in revision details pop-up to WWT: Handle hidden edit summaries in revision details pop-up [small].Wed, Jan 8, 12:24 AM
ifried moved this task from To be estimated/discussed to Estimated on the Community-Tech board.
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban-Q3-2019-20). · View Herald TranscriptWed, Jan 8, 1:13 AM
HMonroy claimed this task.Thu, Jan 9, 1:30 AM
HMonroy moved this task from Ready to In Development on the Community-Tech (Kanban-Q3-2019-20) board.

Note: I'm fairly sure this will be a lot easier to do (if not outright fixed?) with the refactoring PR at https://github.com/wikimedia/WhoWroteThat/pull/128

Note: I'm fairly sure this will be a lot easier to do (if not outright fixed?) with the refactoring PR at https://github.com/wikimedia/WhoWroteThat/pull/128

I believe this issue was fixed with this pull request. I'm no longer able to replicate it.

Note: I'm fairly sure this will be a lot easier to do (if not outright fixed?) with the refactoring PR at https://github.com/wikimedia/WhoWroteThat/pull/128

I believe this issue was fixed with this pull request. I'm no longer able to replicate it.

Although it does not show "(edit summary removed)". The edit summary is just blank.