Page MenuHomePhabricator

"L" shaped line in qualifier display renders incorrectly in chrome after publish
Closed, ResolvedPublic

Description

Upon publish, the visual indicator ("L" shaped line) for qualifiers renders incorrectly in Chrome. Instead it looks like a dash:

Screenshot 2019-12-18 14.14.30.png (580×1 px, 65 KB)

It should look like this (seems to render fine in Firefox):

Screenshot 2019-12-18 16.20.05.png (812×1 px, 126 KB)

COVID-19 Deployment Criteria

  • Can you roll back this change without lasting impact?
    1. A recovery plan is required as this will help identify our capacity for recovering from the failure
    2. THIS IS A KEY QUESTION, if you can’t answer it, you shouldn’t deploy
  • Is specialized knowledge required to support this change in production? If so, are there multiple people with this knowledge?
  • Is there a way to increase confidence about the correctness of this change?
    1. Reviews (Design, Code, etc)
    2. Testing coverage (unit tests, integration tests)
    3. Manual testing (e.g. Beta, vagrant, docker)

Event Timeline

Cparle renamed this task from Fix bug at the qualifier level to "L" shaped line in qualifier display renders incorrectly in chrome after publish.Jan 6 2020, 12:06 PM

I took a look at this and couldn't reproduce it in Chrome 79.0.3945.88. I've seen this behavior before locally when I've broken the publish functionality in some way, but never when things are working (including when errors are present but handled properly).

This also happens on UploadWizard sometimes.

I'm also unable to reproduce ATM. Should we close this ticket until someone manages to find steps to reproduce (if this still happens)?

It still happens, but it's less frequent on File Page now. Last time I saw it was on UploadWizard, but it's difficult to find a specific action that makes it show up all the time.

I have a patch open for improvement to the pending state in qualifiers (see T228947): let's re-asses this ticket once that patch is merged and see if the problem persists.

@egardner, now that T228947 is complete, can you see if this still persists?

I am unable to reproduce this behavior on the File page at the moment. I think the pending state improvements from T228947 hide what was previously happening in this scenario.

UploadWizard handles pending state differently, so you can still see a flash of weird qualifier UI during the publishing process if on a slow connection. I'd post a screen recording but Phabricator is not allowing me to upload files today. Everything looks correct when all the requests complete.

Seems to be fixed/can't reproduce anymore.