Page MenuHomePhabricator

Toolbar: Don't allow sending wikilove with no recipient
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Open wikilove part of the toolbar
  • Select "Send WikiLove" without selecting any editors
  • Proceed through wikilove interface, and send

Expected result:
Error given lack of recipients

Actual result:
Since wikilove can also be activate from a user page, if no recipients are specified when the interface is opened, the default is to try and send to mw.config.get( 'wgTitle' ), which isn't a good idea in this case (sending wikilove to an article)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 559270 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] WikiLove: Don't allow sending to no one

https://gerrit.wikimedia.org/r/559270

Change 559270 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] WikiLove: Don't allow sending to no one

https://gerrit.wikimedia.org/r/559270

MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.