tags do not render in preview properly
Closed, ResolvedPublic
Actions

Description

As first reported here: Usability test: Version 1.0 prototype, comments with <gallery>...</gallery> tags do not render in the reply preview properly.

Expected behavior

https://visualeditor-prototype.wmflabs.org/wiki/Talk:Reply_test

Screen Shot 2019-12-19 at 4.48.26 PM.png (423×1 px, 165 KB)

Actual behavior

https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats

Screen Shot 2019-12-19 at 4.41.02 PM.png (1×1 px, 189 KB)

Steps to reproduce

Go to: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats
Click any "Reply" link, regardless of how deeply it is indented
Input the "Snippet" below into the reply text input

⚠️4. Preview shows images in a bulleted list instead of in a gallery, as shown in "Expected behavior" above

Snippet

<gallery>
File:Detroit Publishing Co. - A Yeoman of the Guard (N.B. actually a Yeoman Warder), full restoration.jpg|1
File:Official_program_-_Woman_suffrage_procession_March_3,_1913_-_crop.jpg|2
File:Thurston, the famous magician - East Indian Rope Trick.jpg|3
File:Joseph Ferdinand Keppler - The Pirate Publisher - Puck Magazine - Restoration by Adam Cuerden.jpg|4
</gallery>

Details

	Subject	Repo	Branch	Lines +/-
	ReplyWidget: Load modules required by the content when previewing	mediawiki/extensions/DiscussionTools	master	+13 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T233443 [Epic] Reply Tool
		Resolved		matmarex	T241193 Replies with <gallery>...</gallery> tags do not render in preview properly

Event Timeline

• ppelberg created this task.Dec 20 2019, 1:04 AM

JJMC89 renamed this task from Replies wrapped in <gallery>...</gallery> tags do not render in preview properly to Replies with <gallery>...</gallery> tags do not render in preview properly.Dec 20 2019, 3:55 AM

JJMC89 updated the task description. (Show Details)

This bug also happens for other things that use the results of the parse API to create previews, including the wikEd gadget.

You need to add modules to the prop parameter. Then the result will contain something like "modulestyles": ["mediawiki.page.gallery.styles"], which is the module you need to load to get the missing CSS.

(This works on https://visualeditor-prototype.wmflabs.org/wiki/Talk:Reply_test because that page already contains a <gallery> tag, so the necessary styles are already loaded.)

Change 561659 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Load modules required by the content when previewing

https://gerrit.wikimedia.org/r/561659

gerritbot added a project: Patch-For-Review.Jan 2 2020, 3:00 PM

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jan 4 2020, 3:24 PM

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jan 4 2020, 3:27 PM

• ppelberg mentioned this in T235923: Replies v1.0: release replying to specific comments.Jan 8 2020, 1:07 AM

Esanders moved this task from Code review to Engineering QA on the VisualEditor (Current work) board.Jan 8 2020, 9:56 PM

Change 561659 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Load modules required by the content when previewing

https://gerrit.wikimedia.org/r/561659

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 9 2020, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2020, 12:11 AM

matmarex moved this task from Engineering QA to Product owner review on the VisualEditor (Current work) board.Feb 3 2020, 6:54 PM

matmarex added a project: Skipped QA.

JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team.Feb 4 2020, 10:15 PM

JTannerWMF moved this task from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 4 2020, 10:17 PM

JTannerWMF edited projects, added OWC2020 Replying 1.0; removed VisualEditor (Current work), OWC2020.Feb 4 2020, 10:49 PM

JTannerWMF added a project: OWC2020 (OWC2020 Replying 1.0).Feb 4 2020, 11:29 PM

JTannerWMF moved this task from Needs Prioritization to Nice to have on the OWC2020 (OWC2020 Replying 1.0) board.Feb 10 2020, 10:40 PM

• ppelberg closed this task as Resolved.Feb 11 2020, 12:54 AM