Page MenuHomePhabricator

Organize and improve integration test coverage for WDQS Updater
Closed, DeclinedPublic

Description

  • Verify test coverage for Updater
  • Create E2E test
  • Review previous tests ( remove duplicated cases)
  • Drop dependencies on real resources in integration tests
  • Rework wikibase integration test

Will be done for the streaming updater.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The most annoying integration test (and probably slowest) is org.wikidata.query.rdf.tool.wikibase.WikibaseRepositoryIntegrationTest:

  • it generates anonymous edits to test.wikidata.org in order to test the RecentChange api
  • Concurrent runs of this test will cause failure. The test expects to see the timestamp of the edits it makes, if this test is run concurrently (two patches in CI) it's a race and can fail.
  • it adds a lot of complexity to test the robustness (retries) by launching a custom Proxy prior running the integration tests (start-proxy and org.wikidata.query.rdf.tool.Proxy)
Zbyszko updated the task description. (Show Details)

Will be done for the streaming updater.