With T227432 now done, there is no varnish-be left.
This task tracks the various cleanups possible at this point, including puppet work such as moving from role::cache::text_ats to role::cache::text, other refactorings and removals of varnish-be leftovers. Similar work can be done when it comes to: VCL, mtail scripts, grafana dashboards, ...
Change 561878 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: rename cache::text_ats role to cache::text
Change 561881 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: make backend_services default to 'ats-be'
Change 561878 merged by Ema:
[operations/puppet@production] cache: rename cache::text_ats role to cache::text
Change 562225 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] prometheus: re-add varnish-text_mtail jobs
Change 562225 merged by Ema:
[operations/puppet@production] prometheus: re-add varnish-text_mtail jobs
Change 561881 merged by Ema:
[operations/puppet@production] cache: make backend_services default to 'ats-be'
Change 562231 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove profile::cache::varnish::backend and cron_restart
Change 562232 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish-backend-restart
Change 562253 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove directors.vcl.tpl.erb
Change 562254 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish-be from profile::cache::base::default_weights
Change 562255 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish::logging::backend
Change 562256 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnishmtail-backend
Change 562257 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove check_varnish_expiry_mailbox_lag.sh
Change 562258 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: do not pick varnish-be as origins for varnish-fe
Change 562260 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge common_vcl_config into fe_vcl_config
Change 562231 merged by Ema:
[operations/puppet@production] cache: remove profile::cache::varnish::backend and cron_restart
Change 562232 merged by Ema:
[operations/puppet@production] cache: remove varnish-backend-restart
Change 562253 merged by Ema:
[operations/puppet@production] cache: remove directors.vcl.tpl.erb
Change 562254 merged by Ema:
[operations/puppet@production] cache: remove varnish-be from profile::cache::base::default_weights
Change 562255 merged by Ema:
[operations/puppet@production] cache: remove varnish::logging::backend
Change 562256 merged by Ema:
[operations/puppet@production] cache: remove varnishmtail-backend
Change 562257 merged by Ema:
[operations/puppet@production] cache: remove check_varnish_expiry_mailbox_lag.sh
Change 562258 merged by Ema:
[operations/puppet@production] cache: do not pick varnish-be as origins for varnish-fe
Change 562260 merged by Ema:
[operations/puppet@production] cache: merge common_vcl_config into fe_vcl_config
Change 562279 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnishbackend.mtail
Change 562279 merged by Ema:
[operations/puppet@production] cache: remove varnishbackend.mtail
Change 564700 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: enable geoiplookup in labs
Change 564700 merged by Ema:
[operations/puppet@production] cache: enable geoiplookup in labs
Change 564726 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: add CAP_KILL to varnish-frontend capabilities
Change 565602 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: move varnish::instance to profile
Change 566536 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'enable_geoiplookup' from vcl_config
Change 566536 merged by Ema:
[operations/puppet@production] cache: remove 'enable_geoiplookup' from vcl_config
Change 566554 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove backend-specific VCL files
Change 566554 merged by Ema:
[operations/puppet@production] cache: remove backend-specific VCL files
Change 566696 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove app_directors and app_def_be_opts
Change 566565 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/puppet@production] prometheus: Remove varnish-backend cluster config
Change 566566 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/puppet@production] prometheus: Clean up varnish-backend cluster config
Change 566700 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove unused parameter 'cache_route'
Change 566565 merged by Vgutierrez:
[operations/puppet@production] prometheus: Remove varnish-backend cluster config
Change 566696 merged by Ema:
[operations/puppet@production] cache: remove app_directors and app_def_be_opts
Change 566700 merged by Ema:
[operations/puppet@production] cache: remove unused parameter 'cache_route'
Change 566566 merged by Vgutierrez:
[operations/puppet@production] prometheus: Clean up varnish-backend cluster config
Change 566705 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'inst' VCL template variable
Change 566706 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove be_runtime_params
Change 566705 merged by Ema:
[operations/puppet@production] cache: remove 'inst' VCL template variable
Change 566706 merged by Ema:
[operations/puppet@production] cache: remove be_runtime_params
Change 566707 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: move fe_runtime_params out of varnish::common
Change 566707 merged by Ema:
[operations/puppet@production] cache: move fe_runtime_params out of varnish::common
Change 566752 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge misc-common VCL into misc-frontend
Change 566774 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge upload-common VCL into upload-frontend
Change 566752 merged by Ema:
[operations/puppet@production] cache: merge misc-common VCL into misc-frontend
Change 566787 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge text-common VCL into text-frontend
Change 566797 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove/update cache_text backend VTC
Change 566797 merged by Ema:
[operations/puppet@production] cache: remove/update cache_text backend VTC
Change 566774 merged by Ema:
[operations/puppet@production] cache: merge upload-common VCL into upload-frontend
Change 566787 merged by Ema:
[operations/puppet@production] cache: merge text-common VCL into text-frontend
Change 571689 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] vcl: merge wikimedia-common into wikimedia-frontend
Change 571697 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] vcl: simplify backend listing
Change 571727 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] varnish::instance: remove 'layer'
Change 571689 merged by Ema:
[operations/puppet@production] vcl: merge wikimedia-common into wikimedia-frontend
Mentioned in SAL (#wikimedia-operations) [2020-02-13T10:49:40Z] <ema> cp4027 (cache_text): apply wikimedia-common/wikimedia-frontend VCL merge T241239
Mentioned in SAL (#wikimedia-operations) [2020-02-13T10:59:37Z] <ema> cp4021 (cache_upload): apply wikimedia-common/wikimedia-frontend VCL merge T241239
Mentioned in SAL (#wikimedia-operations) [2020-02-13T11:12:09Z] <ema> A:cp re-enable puppet, leave it to cron to apply wikimedia-common/wikimedia-frontend VCL merge T241239
Change 571697 merged by Ema:
[operations/puppet@production] vcl: simplify backend listing
Change 571727 merged by Ema:
[operations/puppet@production] varnish::instance: remove 'layer'
Change 604048 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove legacy req_handling directives
Change 604048 merged by Ema:
[operations/puppet@production] cache: remove director and other legacy directives
Change 618975 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove '_ats' suffix from DC names
Change 618989 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: move all VCL files to the same directory
Change 618989 merged by Ema:
[operations/puppet@production] cache: move all VCL files to the same directory
Change 619282 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'cache_ats' from 'wikimedia_clusters'
Change 619283 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove cache_ats_ definitions from monitoring::groups
Change 619282 merged by Ema:
[operations/puppet@production] cache: remove 'cache_ats' from 'wikimedia_clusters'
Change 619283 merged by Ema:
[operations/puppet@production] cache: remove cache_ats_ definitions from monitoring::groups
Change 618975 merged by Ema:
[operations/puppet@production] cache: remove '_ats' suffix from DC names
Change 622131 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'backend_services' hiera setting
Change 622131 merged by Ema:
[operations/puppet@production] cache: remove 'backend_services' hiera setting
Change 661073 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] ipsec: Clean up the parts related to cache cluster
Change 661073 merged by Vgutierrez:
[operations/puppet@production] ipsec: Clean up the parts related to cache cluster
Change 675121 had a related patch set uploaded (by Ema; author: Ema):
[operations/puppet@production] varnish: remove setup_filesystem define
Change 675121 merged by Ema:
[operations/puppet@production] varnish: remove setup_filesystem define
Change 699377 had a related patch set uploaded (by Ema; author: Ema):
[operations/puppet@production] varnish: remove ats-be migration leftover from varnishttfb
Change 699377 merged by Ema:
[operations/puppet@production] varnish: remove ats-be migration leftover from varnishttfb
@ema I'm going to assume we're done with all the easy cleanups here. There's one un-merged patch on this at https://gerrit.wikimedia.org/r/c/operations/puppet/+/565602 - but it never passed CI and is now like 20 months old and probably too stale. Feel free to re-open (or attach some small trailing commits here while closed) if there's other pressing ones that won't be obviated by future changes or can go in a future debt-reduction cycle.
Change 735382 had a related patch set uploaded (by BBlack; author: BBlack):
[operations/puppet@production] Remove max_core_rtt variables
Change 735382 merged by BBlack:
[operations/puppet@production] Remove max_core_rtt variables
Change 736787 had a related patch set uploaded (by Ema; author: Ema):
[operations/puppet@production] prometheus: remove varnish_2layer
Change 736787 merged by Ema:
[operations/puppet@production] prometheus: remove varnish_2layer