Page MenuHomePhabricator

Cleanup after varnish-be -> ats-be migration
Closed, ResolvedPublic

Description

With T227432 now done, there is no varnish-be left.

This task tracks the various cleanups possible at this point, including puppet work such as moving from role::cache::text_ats to role::cache::text, other refactorings and removals of varnish-be leftovers. Similar work can be done when it comes to: VCL, mtail scripts, grafana dashboards, ...

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+5 -8
operations/puppetproduction+0 -32
operations/puppetproduction+0 -41
operations/puppetproduction+2 -4
operations/puppetproduction+15 -24
operations/puppetproduction+0 -12
operations/puppetproduction+0 -9
operations/puppetproduction+2 -2
operations/puppetproduction+66 -99
operations/puppetproduction+2 -4
operations/puppetproduction+39 -71
operations/puppetproduction+458 -505
operations/puppetproduction+198 -225
operations/puppetproduction+67 -100
operations/puppetproduction+9 -242
operations/puppetproduction+20 -25
operations/puppetproduction+10 -12
operations/puppetproduction+1 -13
operations/puppetproduction+8 -13
operations/puppetproduction+0 -11
operations/puppetproduction+0 -9
operations/puppetproduction+5 -98
operations/puppetproduction+1 -0
operations/puppetproduction+0 -408
operations/puppetproduction+3 -3
operations/puppetproduction+249 -298
operations/puppetproduction+2 -7
operations/puppetproduction+1 -0
operations/puppetproduction+0 -95
operations/puppetproduction+5 -9
operations/puppetproduction+1 -9
operations/puppetproduction+0 -29
operations/puppetproduction+0 -33
operations/puppetproduction+0 -44
operations/puppetproduction+0 -1
operations/puppetproduction+0 -12
operations/puppetproduction+1 -40
operations/puppetproduction+0 -261
operations/puppetproduction+1 -3
operations/puppetproduction+3 -4
operations/puppetproduction+15 -566
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ema triaged this task as Medium priority.Dec 20 2019, 1:51 PM
ema moved this task from Triage to Caching on the Traffic board.

Change 561878 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: rename cache::text_ats role to cache::text

https://gerrit.wikimedia.org/r/561878

Change 561881 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: make backend_services default to 'ats-be'

https://gerrit.wikimedia.org/r/561881

Change 561878 merged by Ema:
[operations/puppet@production] cache: rename cache::text_ats role to cache::text

https://gerrit.wikimedia.org/r/561878

Change 562225 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] prometheus: re-add varnish-text_mtail jobs

https://gerrit.wikimedia.org/r/562225

Change 562225 merged by Ema:
[operations/puppet@production] prometheus: re-add varnish-text_mtail jobs

https://gerrit.wikimedia.org/r/562225

Change 561881 merged by Ema:
[operations/puppet@production] cache: make backend_services default to 'ats-be'

https://gerrit.wikimedia.org/r/561881

Change 562231 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove profile::cache::varnish::backend and cron_restart

https://gerrit.wikimedia.org/r/562231

Change 562232 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish-backend-restart

https://gerrit.wikimedia.org/r/562232

Change 562253 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove directors.vcl.tpl.erb

https://gerrit.wikimedia.org/r/562253

Change 562254 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish-be from profile::cache::base::default_weights

https://gerrit.wikimedia.org/r/562254

Change 562255 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish::logging::backend

https://gerrit.wikimedia.org/r/562255

Change 562256 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnishmtail-backend

https://gerrit.wikimedia.org/r/562256

Change 562257 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove check_varnish_expiry_mailbox_lag.sh

https://gerrit.wikimedia.org/r/562257

Change 562258 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: do not pick varnish-be as origins for varnish-fe

https://gerrit.wikimedia.org/r/562258

Change 562260 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge common_vcl_config into fe_vcl_config

https://gerrit.wikimedia.org/r/562260

Change 562231 merged by Ema:
[operations/puppet@production] cache: remove profile::cache::varnish::backend and cron_restart

https://gerrit.wikimedia.org/r/562231

Change 562232 merged by Ema:
[operations/puppet@production] cache: remove varnish-backend-restart

https://gerrit.wikimedia.org/r/562232

Change 562253 merged by Ema:
[operations/puppet@production] cache: remove directors.vcl.tpl.erb

https://gerrit.wikimedia.org/r/562253

Change 562254 merged by Ema:
[operations/puppet@production] cache: remove varnish-be from profile::cache::base::default_weights

https://gerrit.wikimedia.org/r/562254

Change 562255 merged by Ema:
[operations/puppet@production] cache: remove varnish::logging::backend

https://gerrit.wikimedia.org/r/562255

Change 562256 merged by Ema:
[operations/puppet@production] cache: remove varnishmtail-backend

https://gerrit.wikimedia.org/r/562256

Change 562257 merged by Ema:
[operations/puppet@production] cache: remove check_varnish_expiry_mailbox_lag.sh

https://gerrit.wikimedia.org/r/562257

Change 562258 merged by Ema:
[operations/puppet@production] cache: do not pick varnish-be as origins for varnish-fe

https://gerrit.wikimedia.org/r/562258

Change 562260 merged by Ema:
[operations/puppet@production] cache: merge common_vcl_config into fe_vcl_config

https://gerrit.wikimedia.org/r/562260

Change 562279 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnishbackend.mtail

https://gerrit.wikimedia.org/r/562279

Change 562279 merged by Ema:
[operations/puppet@production] cache: remove varnishbackend.mtail

https://gerrit.wikimedia.org/r/562279

Change 564700 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: enable geoiplookup in labs

https://gerrit.wikimedia.org/r/564700

Change 564700 merged by Ema:
[operations/puppet@production] cache: enable geoiplookup in labs

https://gerrit.wikimedia.org/r/564700

Change 564726 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: add CAP_KILL to varnish-frontend capabilities

https://gerrit.wikimedia.org/r/564726

Change 565602 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: move varnish::instance to profile

https://gerrit.wikimedia.org/r/565602

Change 566536 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'enable_geoiplookup' from vcl_config

https://gerrit.wikimedia.org/r/566536

Change 566536 merged by Ema:
[operations/puppet@production] cache: remove 'enable_geoiplookup' from vcl_config

https://gerrit.wikimedia.org/r/566536

Change 566554 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove backend-specific VCL files

https://gerrit.wikimedia.org/r/566554

Change 566554 merged by Ema:
[operations/puppet@production] cache: remove backend-specific VCL files

https://gerrit.wikimedia.org/r/566554

Change 566696 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove app_directors and app_def_be_opts

https://gerrit.wikimedia.org/r/566696

Change 566565 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/puppet@production] prometheus: Remove varnish-backend cluster config

https://gerrit.wikimedia.org/r/566565

Change 566566 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/puppet@production] prometheus: Clean up varnish-backend cluster config

https://gerrit.wikimedia.org/r/566566

Change 566700 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove unused parameter 'cache_route'

https://gerrit.wikimedia.org/r/566700

Change 566565 merged by Vgutierrez:
[operations/puppet@production] prometheus: Remove varnish-backend cluster config

https://gerrit.wikimedia.org/r/566565

Change 566696 merged by Ema:
[operations/puppet@production] cache: remove app_directors and app_def_be_opts

https://gerrit.wikimedia.org/r/566696

Change 566700 merged by Ema:
[operations/puppet@production] cache: remove unused parameter 'cache_route'

https://gerrit.wikimedia.org/r/566700

Change 566566 merged by Vgutierrez:
[operations/puppet@production] prometheus: Clean up varnish-backend cluster config

https://gerrit.wikimedia.org/r/566566

Change 566705 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'inst' VCL template variable

https://gerrit.wikimedia.org/r/566705

Change 566706 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove be_runtime_params

https://gerrit.wikimedia.org/r/566706

Change 566705 merged by Ema:
[operations/puppet@production] cache: remove 'inst' VCL template variable

https://gerrit.wikimedia.org/r/566705

Change 566706 merged by Ema:
[operations/puppet@production] cache: remove be_runtime_params

https://gerrit.wikimedia.org/r/566706

Change 566707 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: move fe_runtime_params out of varnish::common

https://gerrit.wikimedia.org/r/566707

Change 566707 merged by Ema:
[operations/puppet@production] cache: move fe_runtime_params out of varnish::common

https://gerrit.wikimedia.org/r/566707

Change 566752 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge misc-common VCL into misc-frontend

https://gerrit.wikimedia.org/r/566752

Change 566774 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge upload-common VCL into upload-frontend

https://gerrit.wikimedia.org/r/566774

Change 566752 merged by Ema:
[operations/puppet@production] cache: merge misc-common VCL into misc-frontend

https://gerrit.wikimedia.org/r/566752

Change 566787 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge text-common VCL into text-frontend

https://gerrit.wikimedia.org/r/566787

Change 566797 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove/update cache_text backend VTC

https://gerrit.wikimedia.org/r/566797

Change 566797 merged by Ema:
[operations/puppet@production] cache: remove/update cache_text backend VTC

https://gerrit.wikimedia.org/r/566797

Change 566774 merged by Ema:
[operations/puppet@production] cache: merge upload-common VCL into upload-frontend

https://gerrit.wikimedia.org/r/566774

Change 566787 merged by Ema:
[operations/puppet@production] cache: merge text-common VCL into text-frontend

https://gerrit.wikimedia.org/r/566787

Change 571689 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] vcl: merge wikimedia-common into wikimedia-frontend

https://gerrit.wikimedia.org/r/571689

Change 571697 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] vcl: simplify backend listing

https://gerrit.wikimedia.org/r/571697

Change 571727 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] varnish::instance: remove 'layer'

https://gerrit.wikimedia.org/r/571727

Change 571689 merged by Ema:
[operations/puppet@production] vcl: merge wikimedia-common into wikimedia-frontend

https://gerrit.wikimedia.org/r/571689

Mentioned in SAL (#wikimedia-operations) [2020-02-13T10:49:40Z] <ema> cp4027 (cache_text): apply wikimedia-common/wikimedia-frontend VCL merge T241239

Mentioned in SAL (#wikimedia-operations) [2020-02-13T10:59:37Z] <ema> cp4021 (cache_upload): apply wikimedia-common/wikimedia-frontend VCL merge T241239

Mentioned in SAL (#wikimedia-operations) [2020-02-13T11:12:09Z] <ema> A:cp re-enable puppet, leave it to cron to apply wikimedia-common/wikimedia-frontend VCL merge T241239

Change 571697 merged by Ema:
[operations/puppet@production] vcl: simplify backend listing

https://gerrit.wikimedia.org/r/571697

Change 571727 merged by Ema:
[operations/puppet@production] varnish::instance: remove 'layer'

https://gerrit.wikimedia.org/r/571727

Change 604048 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove legacy req_handling directives

https://gerrit.wikimedia.org/r/604048

Change 604048 merged by Ema:
[operations/puppet@production] cache: remove director and other legacy directives

https://gerrit.wikimedia.org/r/604048

Change 618975 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove '_ats' suffix from DC names

https://gerrit.wikimedia.org/r/618975

Change 618989 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: move all VCL files to the same directory

https://gerrit.wikimedia.org/r/618989

Change 618989 merged by Ema:
[operations/puppet@production] cache: move all VCL files to the same directory

https://gerrit.wikimedia.org/r/618989

Change 619282 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'cache_ats' from 'wikimedia_clusters'

https://gerrit.wikimedia.org/r/619282

Change 619283 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove cache_ats_ definitions from monitoring::groups

https://gerrit.wikimedia.org/r/619283

Change 619282 merged by Ema:
[operations/puppet@production] cache: remove 'cache_ats' from 'wikimedia_clusters'

https://gerrit.wikimedia.org/r/619282

Change 619283 merged by Ema:
[operations/puppet@production] cache: remove cache_ats_ definitions from monitoring::groups

https://gerrit.wikimedia.org/r/619283

Change 618975 merged by Ema:
[operations/puppet@production] cache: remove '_ats' suffix from DC names

https://gerrit.wikimedia.org/r/618975

Change 622131 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'backend_services' hiera setting

https://gerrit.wikimedia.org/r/622131

Change 622131 merged by Ema:
[operations/puppet@production] cache: remove 'backend_services' hiera setting

https://gerrit.wikimedia.org/r/622131

Change 661073 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/puppet@production] ipsec: Clean up the parts related to cache cluster

https://gerrit.wikimedia.org/r/661073

Change 661073 merged by Vgutierrez:
[operations/puppet@production] ipsec: Clean up the parts related to cache cluster

https://gerrit.wikimedia.org/r/661073

Change 675121 had a related patch set uploaded (by Ema; author: Ema):
[operations/puppet@production] varnish: remove setup_filesystem define

https://gerrit.wikimedia.org/r/675121

Change 675121 merged by Ema:
[operations/puppet@production] varnish: remove setup_filesystem define

https://gerrit.wikimedia.org/r/675121

Change 699377 had a related patch set uploaded (by Ema; author: Ema):

[operations/puppet@production] varnish: remove ats-be migration leftover from varnishttfb

https://gerrit.wikimedia.org/r/699377

Change 699377 merged by Ema:

[operations/puppet@production] varnish: remove ats-be migration leftover from varnishttfb

https://gerrit.wikimedia.org/r/699377

BBlack assigned this task to ema.
BBlack added a subscriber: BBlack.

@ema I'm going to assume we're done with all the easy cleanups here. There's one un-merged patch on this at https://gerrit.wikimedia.org/r/c/operations/puppet/+/565602 - but it never passed CI and is now like 20 months old and probably too stale. Feel free to re-open (or attach some small trailing commits here while closed) if there's other pressing ones that won't be obviated by future changes or can go in a future debt-reduction cycle.