Page MenuHomePhabricator

Cleanup after varnish-be -> ats-be migration
Open, MediumPublic

Description

With T227432 now done, there is no varnish-be left.

This task tracks the various cleanups possible at this point, including puppet work such as moving from role::cache::text_ats to role::cache::text, other refactorings and removals of varnish-be leftovers. Similar work can be done when it comes to: VCL, mtail scripts, grafana dashboards, ...

Details

Related Gerrit Patches:
operations/puppet : productionvarnish::instance: remove 'layer'
operations/puppet : productionvcl: simplify backend listing
operations/puppet : productionvcl: merge wikimedia-common into wikimedia-frontend
operations/puppet : productioncache: merge text-common VCL into text-frontend
operations/puppet : productioncache: merge upload-common VCL into upload-frontend
operations/puppet : productioncache: remove/update cache_text backend VTC
operations/puppet : productioncache: merge misc-common VCL into misc-frontend
operations/puppet : productioncache: move fe_runtime_params out of varnish::common
operations/puppet : productioncache: remove be_runtime_params
operations/puppet : productioncache: remove 'inst' VCL template variable
operations/puppet : productionprometheus: Clean up varnish-backend cluster config
operations/puppet : productioncache: remove unused parameter 'cache_route'
operations/puppet : productioncache: remove app_directors and app_def_be_opts
operations/puppet : productionprometheus: Remove varnish-backend cluster config
operations/puppet : productioncache: remove backend-specific VCL files
operations/puppet : productioncache: remove 'enable_geoiplookup' from vcl_config
operations/puppet : productioncache: move varnish::instance into profile
operations/puppet : productioncache: add CAP_KILL to varnish-frontend capabilities
operations/puppet : productioncache: enable geoiplookup in labs
operations/puppet : productioncache: remove varnishbackend.mtail
operations/puppet : productioncache: merge common_vcl_config into fe_vcl_config
operations/puppet : productioncache: do not pick varnish-be as origins for varnish-fe
operations/puppet : productioncache: remove check_varnish_expiry_mailbox_lag.sh
operations/puppet : productioncache: remove varnishmtail-backend
operations/puppet : productioncache: remove varnish::logging::backend
operations/puppet : productioncache: remove varnish-be from profile::cache::base::default_weights
operations/puppet : productioncache: remove directors.vcl.tpl.erb
operations/puppet : productioncache: remove varnish-backend-restart
operations/puppet : productioncache: remove profile::cache::varnish::backend and cron_restart
operations/puppet : productioncache: make backend_services default to 'ats-be'
operations/puppet : productionprometheus: re-add varnish-text_mtail jobs
operations/puppet : productioncache: rename cache::text_ats role to cache::text

Event Timeline

ema created this task.Dec 20 2019, 1:51 PM
Restricted Application added a project: Operations. · View Herald TranscriptDec 20 2019, 1:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ema triaged this task as Medium priority.Dec 20 2019, 1:51 PM
ema moved this task from Triage to Caching on the Traffic board.

Change 561878 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: rename cache::text_ats role to cache::text

https://gerrit.wikimedia.org/r/561878

Change 561881 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: make backend_services default to 'ats-be'

https://gerrit.wikimedia.org/r/561881

Change 561878 merged by Ema:
[operations/puppet@production] cache: rename cache::text_ats role to cache::text

https://gerrit.wikimedia.org/r/561878

Change 562225 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] prometheus: re-add varnish-text_mtail jobs

https://gerrit.wikimedia.org/r/562225

Change 562225 merged by Ema:
[operations/puppet@production] prometheus: re-add varnish-text_mtail jobs

https://gerrit.wikimedia.org/r/562225

Change 561881 merged by Ema:
[operations/puppet@production] cache: make backend_services default to 'ats-be'

https://gerrit.wikimedia.org/r/561881

Change 562231 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove profile::cache::varnish::backend and cron_restart

https://gerrit.wikimedia.org/r/562231

Change 562232 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish-backend-restart

https://gerrit.wikimedia.org/r/562232

Change 562253 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove directors.vcl.tpl.erb

https://gerrit.wikimedia.org/r/562253

Change 562254 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish-be from profile::cache::base::default_weights

https://gerrit.wikimedia.org/r/562254

Change 562255 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnish::logging::backend

https://gerrit.wikimedia.org/r/562255

Change 562256 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnishmtail-backend

https://gerrit.wikimedia.org/r/562256

Change 562257 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove check_varnish_expiry_mailbox_lag.sh

https://gerrit.wikimedia.org/r/562257

Change 562258 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: do not pick varnish-be as origins for varnish-fe

https://gerrit.wikimedia.org/r/562258

Change 562260 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge common_vcl_config into fe_vcl_config

https://gerrit.wikimedia.org/r/562260

Change 562231 merged by Ema:
[operations/puppet@production] cache: remove profile::cache::varnish::backend and cron_restart

https://gerrit.wikimedia.org/r/562231

Change 562232 merged by Ema:
[operations/puppet@production] cache: remove varnish-backend-restart

https://gerrit.wikimedia.org/r/562232

Change 562253 merged by Ema:
[operations/puppet@production] cache: remove directors.vcl.tpl.erb

https://gerrit.wikimedia.org/r/562253

Change 562254 merged by Ema:
[operations/puppet@production] cache: remove varnish-be from profile::cache::base::default_weights

https://gerrit.wikimedia.org/r/562254

Change 562255 merged by Ema:
[operations/puppet@production] cache: remove varnish::logging::backend

https://gerrit.wikimedia.org/r/562255

Change 562256 merged by Ema:
[operations/puppet@production] cache: remove varnishmtail-backend

https://gerrit.wikimedia.org/r/562256

Change 562257 merged by Ema:
[operations/puppet@production] cache: remove check_varnish_expiry_mailbox_lag.sh

https://gerrit.wikimedia.org/r/562257

Change 562258 merged by Ema:
[operations/puppet@production] cache: do not pick varnish-be as origins for varnish-fe

https://gerrit.wikimedia.org/r/562258

Change 562260 merged by Ema:
[operations/puppet@production] cache: merge common_vcl_config into fe_vcl_config

https://gerrit.wikimedia.org/r/562260

Change 562279 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove varnishbackend.mtail

https://gerrit.wikimedia.org/r/562279

Change 562279 merged by Ema:
[operations/puppet@production] cache: remove varnishbackend.mtail

https://gerrit.wikimedia.org/r/562279

Change 564700 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: enable geoiplookup in labs

https://gerrit.wikimedia.org/r/564700

Change 564700 merged by Ema:
[operations/puppet@production] cache: enable geoiplookup in labs

https://gerrit.wikimedia.org/r/564700

Change 564726 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: add CAP_KILL to varnish-frontend capabilities

https://gerrit.wikimedia.org/r/564726

Change 565602 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: move varnish::instance to profile

https://gerrit.wikimedia.org/r/565602

Change 566536 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'enable_geoiplookup' from vcl_config

https://gerrit.wikimedia.org/r/566536

Change 566536 merged by Ema:
[operations/puppet@production] cache: remove 'enable_geoiplookup' from vcl_config

https://gerrit.wikimedia.org/r/566536

Change 566554 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove backend-specific VCL files

https://gerrit.wikimedia.org/r/566554

Change 566554 merged by Ema:
[operations/puppet@production] cache: remove backend-specific VCL files

https://gerrit.wikimedia.org/r/566554

Change 566696 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove app_directors and app_def_be_opts

https://gerrit.wikimedia.org/r/566696

Change 566565 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/puppet@production] prometheus: Remove varnish-backend cluster config

https://gerrit.wikimedia.org/r/566565

Change 566566 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/puppet@production] prometheus: Clean up varnish-backend cluster config

https://gerrit.wikimedia.org/r/566566

Change 566700 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove unused parameter 'cache_route'

https://gerrit.wikimedia.org/r/566700

Change 566565 merged by Vgutierrez:
[operations/puppet@production] prometheus: Remove varnish-backend cluster config

https://gerrit.wikimedia.org/r/566565

Change 566696 merged by Ema:
[operations/puppet@production] cache: remove app_directors and app_def_be_opts

https://gerrit.wikimedia.org/r/566696

Change 566700 merged by Ema:
[operations/puppet@production] cache: remove unused parameter 'cache_route'

https://gerrit.wikimedia.org/r/566700

Change 566566 merged by Vgutierrez:
[operations/puppet@production] prometheus: Clean up varnish-backend cluster config

https://gerrit.wikimedia.org/r/566566

Change 566705 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove 'inst' VCL template variable

https://gerrit.wikimedia.org/r/566705

Change 566706 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove be_runtime_params

https://gerrit.wikimedia.org/r/566706

Change 566705 merged by Ema:
[operations/puppet@production] cache: remove 'inst' VCL template variable

https://gerrit.wikimedia.org/r/566705

Change 566706 merged by Ema:
[operations/puppet@production] cache: remove be_runtime_params

https://gerrit.wikimedia.org/r/566706

Change 566707 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: move fe_runtime_params out of varnish::common

https://gerrit.wikimedia.org/r/566707

Change 566707 merged by Ema:
[operations/puppet@production] cache: move fe_runtime_params out of varnish::common

https://gerrit.wikimedia.org/r/566707

Change 566752 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge misc-common VCL into misc-frontend

https://gerrit.wikimedia.org/r/566752

Change 566774 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge upload-common VCL into upload-frontend

https://gerrit.wikimedia.org/r/566774

Change 566752 merged by Ema:
[operations/puppet@production] cache: merge misc-common VCL into misc-frontend

https://gerrit.wikimedia.org/r/566752

Change 566787 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: merge text-common VCL into text-frontend

https://gerrit.wikimedia.org/r/566787

Change 566797 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] cache: remove/update cache_text backend VTC

https://gerrit.wikimedia.org/r/566797

Change 566797 merged by Ema:
[operations/puppet@production] cache: remove/update cache_text backend VTC

https://gerrit.wikimedia.org/r/566797

Change 566774 merged by Ema:
[operations/puppet@production] cache: merge upload-common VCL into upload-frontend

https://gerrit.wikimedia.org/r/566774

Change 566787 merged by Ema:
[operations/puppet@production] cache: merge text-common VCL into text-frontend

https://gerrit.wikimedia.org/r/566787

Change 571689 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] vcl: merge wikimedia-common into wikimedia-frontend

https://gerrit.wikimedia.org/r/571689

Change 571697 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] vcl: simplify backend listing

https://gerrit.wikimedia.org/r/571697

Change 571727 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] varnish::instance: remove 'layer'

https://gerrit.wikimedia.org/r/571727

Change 571689 merged by Ema:
[operations/puppet@production] vcl: merge wikimedia-common into wikimedia-frontend

https://gerrit.wikimedia.org/r/571689

Mentioned in SAL (#wikimedia-operations) [2020-02-13T10:49:40Z] <ema> cp4027 (cache_text): apply wikimedia-common/wikimedia-frontend VCL merge T241239

Mentioned in SAL (#wikimedia-operations) [2020-02-13T10:59:37Z] <ema> cp4021 (cache_upload): apply wikimedia-common/wikimedia-frontend VCL merge T241239

Mentioned in SAL (#wikimedia-operations) [2020-02-13T11:12:09Z] <ema> A:cp re-enable puppet, leave it to cron to apply wikimedia-common/wikimedia-frontend VCL merge T241239

Change 571697 merged by Ema:
[operations/puppet@production] vcl: simplify backend listing

https://gerrit.wikimedia.org/r/571697

Change 571727 merged by Ema:
[operations/puppet@production] varnish::instance: remove 'layer'

https://gerrit.wikimedia.org/r/571727