Page MenuHomePhabricator
Create Task
Maniphest T241340

PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28
Closed, ResolvedPublic
Actions

Description

Since upgrading to MediaWiki 1.34 today, we have seen "PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28" in the logs.

Running php 7.3.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't redefine MW_ENTRY_POINT in thumb.php if already definedmediawiki/coremaster+5 -1
Don't redefine MW_ENTRY_POINT in thumb.php if already definedmediawiki/coreREL1_34+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Paladox created this task.Dec 23 2019, 12:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2019, 12:03 AM
Paladox added a subscriber: Tgr.Dec 23 2019, 2:48 PM
Paladox added a comment.Dec 23 2019, 2:50 PM

This is causing a lot of log spam.

I guess it's because thumb_handler calls thumb.php?

gerritbot added a comment.Dec 23 2019, 6:17 PM

Change 560418 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Don't redefine MW_ENTRY_POINT in thumb.php if already defined

https://gerrit.wikimedia.org/r/560418

gerritbot added a project: Patch-For-Review.Dec 23 2019, 6:17 PM
Reedy added a project: MW-1.34-release.Dec 23 2019, 6:19 PM
Reedy added a comment.Dec 23 2019, 6:45 PM

Caused by b7ce7aacb0fb6803d9135f465e9cf6b48912883e / I24099f4cdd170de17afd6e1bbad67c9b204071fc

gerritbot added a comment.Dec 23 2019, 6:46 PM

Change 560422 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_34] Don't redefine MW_ENTRY_POINT in thumb.php if already defined

https://gerrit.wikimedia.org/r/560422

gerritbot added a comment.Dec 23 2019, 6:55 PM

Change 560422 merged by jenkins-bot:
[mediawiki/core@REL1_34] Don't redefine MW_ENTRY_POINT in thumb.php if already defined

https://gerrit.wikimedia.org/r/560422

ReleaseTaggerBot added a project: MW-1.34-notes.Dec 23 2019, 7:00 PM
gerritbot added a comment.Dec 23 2019, 10:15 PM

Change 560418 merged by jenkins-bot:
[mediawiki/core@master] Don't redefine MW_ENTRY_POINT in thumb.php if already defined

https://gerrit.wikimedia.org/r/560418

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 23 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 23 2019, 11:10 PM
xSavitar subscribed.EditedJan 19 2020, 2:30 PM

Does this still causes log spams? I guess not?

xSavitar triaged this task as Low priority.Jan 19 2020, 2:30 PM
Reedy closed this task as Resolved.Jan 19 2020, 2:54 PM
Reedy claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits