Page MenuHomePhabricator

PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28
Closed, ResolvedPublic

Description

Since upgrading to MediaWiki 1.34 today, we have seen "PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28" in the logs.

Running php 7.3.

Event Timeline

This is causing a lot of log spam.

I guess it's because thumb_handler calls thumb.php?

Change 560418 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Don't redefine MW_ENTRY_POINT in thumb.php if already defined

https://gerrit.wikimedia.org/r/560418

Change 560422 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_34] Don't redefine MW_ENTRY_POINT in thumb.php if already defined

https://gerrit.wikimedia.org/r/560422

Change 560422 merged by jenkins-bot:
[mediawiki/core@REL1_34] Don't redefine MW_ENTRY_POINT in thumb.php if already defined

https://gerrit.wikimedia.org/r/560422

Change 560418 merged by jenkins-bot:
[mediawiki/core@master] Don't redefine MW_ENTRY_POINT in thumb.php if already defined

https://gerrit.wikimedia.org/r/560418

Does this still causes log spams? I guess not?

Reedy claimed this task.