Page MenuHomePhabricator
Create Task
Maniphest T241341

Remove Title::isValidMoveOperation(), ::moveTo(), and ::isValidMoveTarget() (deprecated in favor of MovePage's methods)
Closed, ResolvedPublic
Actions

Description

Usage:

  • Title::isValidMoveOperation - none
  • Title::isValidMoveTarget - none remaining, removal in T241339
  • Title::moveTo - none remaining, removal in T221949

Once the methods are no longer called, they can be safely removed

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove Title move functions, deprecated in favor of MovePage classmediawiki/coremaster+4 -186
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Dec 23 2019, 12:03 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 23 2019, 12:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 changed the task status from Open to Stalled.Dec 23 2019, 12:04 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Awaiting resolution of T241339: Remove uses of Title::isValidMoveTarget in favor of MovePage::isValidMoveTarget and T221949: Remove uses of Title::moveTo

DannyS712 mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Dec 23 2019, 12:04 AM
Aklapper added a project: MediaWiki-General.Dec 23 2019, 5:25 PM

Assuming this task is about MediaWiki-General, hence adding project tag so others can find this task when searching for tasks under that project.

DannyS712 moved this task from Untriaged to <= 2015 / MW 1.26 on the Technical-Debt (Deprecation process) board.Dec 28 2019, 5:07 AM
DannyS712 moved this task from Next to In progress on the User-DannyS712 board.Jan 9 2020, 10:44 PM
DannyS712 updated the task description. (Show Details)Jan 24 2020, 3:07 PM
DannyS712 mentioned this in T221949: Remove uses of Title::moveTo.Jan 29 2020, 8:45 PM
DannyS712 merged a task: T243953: Remove Title::moveTo.Jan 30 2020, 4:15 PM
DannyS712 added a subscriber: Art-Baltai.
DannyS712 mentioned this in T243953: Remove Title::moveTo.Jan 30 2020, 4:35 PM
Aklapper merged a task: T243953: Remove Title::moveTo.Jan 30 2020, 6:33 PM
DannyS712 changed the task status from Stalled to Open.Feb 13 2020, 9:55 AM
DannyS712 updated the task description. (Show Details)
gerritbot added a comment.Feb 18 2020, 9:45 PM

Change 572989 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove Title move functions, deprecated in favor of MovePage class

https://gerrit.wikimedia.org/r/572989

gerritbot added a project: Patch-For-Review.Feb 18 2020, 9:45 PM
gerritbot added a comment.Feb 21 2020, 4:50 AM

Change 572989 merged by jenkins-bot:
[mediawiki/core@master] Remove Title move functions, deprecated in favor of MovePage class

https://gerrit.wikimedia.org/r/572989

DannyS712 closed this task as Resolved.Feb 21 2020, 4:54 AM
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 21 2020, 5:00 AM
DannyS712 moved this task from In progress to Resolved (deprecation) on the User-DannyS712 board.Feb 23 2020, 10:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits