Page MenuHomePhabricator
Create Task
Maniphest T241356

Drop FileBasedSiteLookup class, deprecated and unused
Closed, ResolvedPublic
Actions

Description

There are no remaining references to the FileBasedSiteLookup class, and it can be removed
Code search: https://codesearch.wmflabs.org/search/?q=FileBasedSiteLookup&i=nope&files=&repos=

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove `FileBasedSiteLookup` class, deprecated and unusedmediawiki/coremaster+3 -139
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Dec 23 2019, 8:37 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 23 2019, 8:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Dec 23 2019, 8:40 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 moved this task from Untriaged to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.Dec 28 2019, 5:08 AM
gerritbot added a comment.Jan 2 2020, 11:50 PM

Change 561712 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove FileBasedSiteLookup class, deprecated and unused

https://gerrit.wikimedia.org/r/561712

gerritbot added a project: Patch-For-Review.Jan 2 2020, 11:50 PM
DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Jan 2 2020, 11:52 PM
gerritbot added a comment.Jan 4 2020, 11:31 AM

Change 561712 merged by jenkins-bot:
[mediawiki/core@master] Remove FileBasedSiteLookup class, deprecated and unused

https://gerrit.wikimedia.org/r/561712

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Jan 4 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 4 2020, 12:10 PM
DannyS712 closed this task as Resolved.Jan 4 2020, 6:23 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jan 13 2020, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits