Page MenuHomePhabricator
Create Task
Maniphest T241406

Expand phpunit tests for Title.php
Open, Needs TriagePublic
Actions

Description

Currently, only 22.99% of "Functions and Methods" and 34.67% of lines of code are tested

Details

SubjectRepoBranchLines +/-
tests: Cover more methods in the Title::class (increase code coverage)mediawiki/coremaster+112 -0
Add tests for Title::getSelectFieldsmediawiki/coremaster+54 -1
Add more tests for creating Title objectsmediawiki/coremaster+62 -0
Expand title tests for configuration pagesmediawiki/coremaster+49 -55
Expand test coverage for Title classmediawiki/coremaster+136 -3
Expand tests for title classmediawiki/coremaster+311 -0
Add Unit tests for Title classmediawiki/coremaster+66 -0
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Dec 24 2019, 1:45 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 24 2019, 1:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Dec 25 2019, 8:51 AM

Change 560455 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Expand tests for title class

https://gerrit.wikimedia.org/r/560455

gerritbot added a project: Patch-For-Review.Dec 25 2019, 8:51 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Dec 25 2019, 8:51 AM
DannyS712 moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
DannyS712 merged a task: T243758: Add tests for class Title, increase coverage to 75%.Jan 30 2020, 4:19 PM
DannyS712 added subscribers: Peter.ovchyn, daniel.
gerritbot added a comment.Jan 21 2021, 3:51 AM

Change 656472 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add Unit tests for Title class

https://gerrit.wikimedia.org/r/656472

gerritbot added a comment.Jan 21 2021, 4:48 AM

Change 656472 merged by jenkins-bot:
[mediawiki/core@master] Add Unit tests for Title class

https://gerrit.wikimedia.org/r/656472

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 21 2021, 5:00 AM
gerritbot added a comment.Feb 26 2021, 11:19 PM

Change 560455 abandoned by DannyS712:
[mediawiki/core@master] Expand tests for title class

Reason:

https://gerrit.wikimedia.org/r/560455

gerritbot added a comment.Feb 26 2021, 11:20 PM

Change 667259 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Expand test coverage for Title class

https://gerrit.wikimedia.org/r/667259

gerritbot added a comment.Mar 2 2021, 12:29 AM

Change 667259 abandoned by DannyS712:
[mediawiki/core@master] Expand test coverage for Title class

Reason:

https://gerrit.wikimedia.org/r/667259

gerritbot added a comment.Mar 2 2021, 12:34 AM

Change 667662 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Clean up and expand title tests for configuration pages

https://gerrit.wikimedia.org/r/667662

DannyS712 removed DannyS712 as the assignee of this task.Mar 2 2021, 12:55 AM

While I'll still work on this, that shouldn't stop others and I'm happy to review patches

gerritbot added a comment.Mar 2 2021, 7:43 PM

Change 667662 merged by jenkins-bot:
[mediawiki/core@master] Expand title tests for configuration pages

https://gerrit.wikimedia.org/r/667662

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Mar 2 2021, 8:00 PM
gerritbot added a comment.Mar 7 2021, 7:03 PM

Change 668810 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add more tests for creating Title objects

https://gerrit.wikimedia.org/r/668810

gerritbot added a comment.Mar 7 2021, 7:17 PM

Change 668811 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add tests for Title::getSelectFields

https://gerrit.wikimedia.org/r/668811

gerritbot added a comment.Mar 9 2021, 1:19 AM

Change 668810 merged by jenkins-bot:
[mediawiki/core@master] Add more tests for creating Title objects

https://gerrit.wikimedia.org/r/668810

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 2:00 AM
gerritbot added a comment.Jun 6 2021, 2:14 PM

Change 668811 abandoned by DannyS712:

[mediawiki/core@master] Add tests for Title::getSelectFields

Reason:

getSelectFields is now in PageStore and the Title method is deprecated

https://gerrit.wikimedia.org/r/668811

xSavitar awarded a token.Sep 5 2021, 8:04 PM
xSavitar subscribed.
gerritbot added a comment.Sep 5 2021, 8:13 PM

Change 717384 had a related patch set uploaded (by D3r1ck01; author: Derick A):

[mediawiki/core@master] tests: Cover more methods in the Title::class (increase code coverage)

https://gerrit.wikimedia.org/r/717384

gerritbot added a comment.Sep 7 2021, 2:42 PM

Change 717384 merged by jenkins-bot:

[mediawiki/core@master] tests: Cover more methods in the Title::class (increase code coverage)

https://gerrit.wikimedia.org/r/717384

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 7 2021, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL