Page MenuHomePhabricator

Minor HTML+CSS+JS improvements to tool home page
Closed, ResolvedPublic

Description

Task

  1. Tool homepage is lacking <head> and a proper favicon. As of now, lets use our logo from https://github.com/tonythomas01/gdrive_to_commons/issues/14#issuecomment-568453667
  2. Code wise, lets move all the JS scripts in upload.html to somewhere like assets/js/uploader.js ?

Optional, let us also bring in our logo to the nabvar like https://getbootstrap.com/docs/4.0/components/navbar/#brand ?

Setup Guide for GCI students
This is a Google Code In task.

You have to setup the python-django tool Gdrive to Commons locally to start with contributing. We host our code on Github, so the change should come in as a pull request to https://github.com/tonythomas01/gdrive_to_commons. Steps to contribute are similar to Pull request workflow. Or, you can rely on the following:

  1. Create a local fork of https://github.com/tonythomas01/gdrive_to_commons using your account.
  2. Create a branch with the phabricator task name from origin/master. For eg, git checkout -b T55445 origin/master. Make sure to update your local branch by git pull --rebase or whatever necessary before creating a branch.
  3. Fix the issue you are solving.
  4. Commit it (git commit -m "What you fixed goes here")
  5. Push it to your Github fork of the repo (git push -u origin HEAD)
  6. Later, create a pull request to https://github.com/tonythomas01/gdrive_to_commons from Github with your changes.
  7. Would be pretty cool if you also paste your pull request link on your phabricator task so people know that things are moving.

Details

Related Changes in Gerrit:

Event Timeline

Change 623176 had a related patch set uploaded (by Abbasidaniyal; owner: Abbasidaniyal):
[labs/tools/gdrive-to-commons@master] Removed JS code from upload.html

https://gerrit.wikimedia.org/r/623176

Change 623176 merged by jenkins-bot:
[labs/tools/gdrive-to-commons@master] Removed JS code from upload.html

https://gerrit.wikimedia.org/r/623176

Closing it for now. Thank you!