Page MenuHomePhabricator
Create Task
Maniphest T241426

Investigate why importDump.php < xmlfile.xml complains that BackupReader::handleRevision is private
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Mark some more BackupReader functions publicmediawiki/coremaster+3 -3
Customize query in gerrit

Event Timeline

Physikerwelt created this task.Dec 24 2019, 6:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 24 2019, 6:03 PM
Mainframe98 closed this task as a duplicate of T238984: importdump warning: call_user_func() expects parameter 1 to be a valid callback, cannot access private method BackupReader::reportPage() in WikiImporter.php.Dec 24 2019, 6:58 PM
Reedy reopened this task as Open.Dec 24 2019, 9:23 PM
Reedy added a project: MediaWiki-Core-Snapshots.
gerritbot added a comment.Dec 24 2019, 9:29 PM

Change 560547 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Mark some more BackupReader functions public

https://gerrit.wikimedia.org/r/560547

gerritbot added a project: Patch-For-Review.Dec 24 2019, 9:29 PM
Reedy subscribed.Dec 24 2019, 9:29 PM
In T241426#5762873, @gerritbot wrote:

Change 560547 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Mark some more BackupReader functions public

https://gerrit.wikimedia.org/r/560547

Caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/542553/

I noticed two other functions that were called as callbacks in the same part of the code would likely similarly fail - marked as public

Umherirrender closed this task as Resolved.Dec 24 2019, 11:48 PM
Umherirrender assigned this task to Reedy.
Umherirrender triaged this task as Medium priority.
gerritbot added a comment.Dec 25 2019, 12:00 AM

Change 560547 merged by jenkins-bot:
[mediawiki/core@master] Mark some more BackupReader functions public

https://gerrit.wikimedia.org/r/560547

Maintenance_bot removed a project: Patch-For-Review.Dec 25 2019, 12:10 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 25 2019, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL