Page MenuHomePhabricator

Thank api assumes that echo event will go through
Open, Needs TriagePublicBUG REPORT


In ApiCoreThank and ApiFlowThank, after calling EchoEvent::create to send thanks, there is no check that the thanks were actually delivered. Instead, the extension just assumes that the echo events went through. If they are intercepted by another extension, the call to EchoEvent::create will return false. The apis should determine success or failure on the basis of what is returned, rather than assuming success.

Event Timeline