In ApiCoreThank and ApiFlowThank, after calling EchoEvent::create to send thanks, there is no check that the thanks were actually delivered. Instead, the extension just assumes that the echo events went through. If they are intercepted by another extension, the call to EchoEvent::create will return false. The apis should determine success or failure on the basis of what is returned, rather than assuming success.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | Feature | DannyS712 | T235873 Add variables in Abusefilter to detect/block thanks | ||
| Open | BUG REPORT | None | T241474 Thank api assumes that echo event will go through | ||
| Open | Design | None | T241550 Design: What should happen if thanks fails | ||
| Open | None | T169834 Change EchoEvent->create to return Status or throw exceptions, never false | |||
| Open | BUG REPORT | None | T310262 Thanking using the API isn't reflected on action=history, thanking again returns "success" |