Test form for adding acks as a requestor works correctly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Dec 27 2019, 3:57 PM

Project Tags

Referenced Files

None

Subscribers

Urbanecm

Description

Problem

Requestors can add some acks (like "submitted") from the user interface. The ticket/<int:pk>/edit/<str:ack_type>/add/ path is responsible for that. However, the test case testing this doesn't cover the code fully.

Proposed solution

Add tests to [TicketAckTests](https://github.com/wikimedia/wikimedia-cz-tracker/blob/master/trackersite/tracker/tests.py#L618) that will test that:

anonymous users and non-owners get 403 Forbidden when trying to add an ack
posting the form with comment field works
acks can't be added/removed once ticket is archived

Student is expected to send a patch for wikimedia-cz/tracker repository, hosted at Wikimedia Gerrit. When claiming task on GCI website, student should claim a respective Phabricator task as well.

Materials

Tracker in production
Test Tracker version - you can play with Tracker freely here
Codebase

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Add more tests to TicketAckTests	Bjornskjald	wikimedia-cz/tracker	master	+42 -0

Customize query in gerrit

Event Timeline

Urbanecm created this task.Dec 27 2019, 3:57 PM

Change 561177 had a related patch set uploaded (by Bjornskjald; owner: ptrcnull):
[wikimedia-cz/tracker@master] Add more tests to TicketAckTests

https://gerrit.wikimedia.org/r/561177

gerritbot added a project: Patch-For-Review.Dec 30 2019, 10:09 PM

ptrcnull claimed this task.Dec 31 2019, 12:15 AM

Change 561177 merged by jenkins-bot:
[wikimedia-cz/tracker@master] Add more tests to TicketAckTests