Collection needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Dec 31 2019, 1:08 AM

Description

See parent task

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove use of global $wgUser in templates	mediawiki/extensions/Collection	master	+6 -5
	Remove uses of global $wgUser and global $wgCommunityCollectionNamespace	mediawiki/extensions/Collection	master	+11 -11

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved	DannyS712	T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
Resolved	DannyS712	T241616 Collection needs uses of global $wgUser removed

Event Timeline

DannyS712 created this task.Dec 31 2019, 1:08 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 31 2019, 1:08 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 561238 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Collection@master] Remove uses of global $wgUser

https://gerrit.wikimedia.org/r/561238

gerritbot added a project: Patch-For-Review.Dec 31 2019, 1:08 AM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Dec 31 2019, 1:12 AM

DannyS712 added a parent task: T159299: Deprecate and remove $wgUser.

Change 561238 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Remove uses of global $wgUser and global $wgCommunityCollectionNamespace

https://gerrit.wikimedia.org/r/561238

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Jan 1 2020, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 1 2020, 1:10 PM

DannyS712 closed this task as Resolved.Jan 2 2020, 3:13 AM

There's more: https://codesearch.wmflabs.org/search/?q=%5C%24GLOBALS%5C%5B%5B%27%22%5DwgUser%5B%27%22%5D&i=nope&files=&repos=Extension:Collection

Change 562398 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Collection@master] Remove use of global $wgUser in templates

https://gerrit.wikimedia.org/r/562398

gerritbot added a project: Patch-For-Review.Jan 7 2020, 2:14 AM

In T241616#5777483, @Daimona wrote:

There's more: https://codesearch.wmflabs.org/search/?q=%5C%24GLOBALS%5C%5B%5B%27%22%5DwgUser%5B%27%22%5D&i=nope&files=&repos=Extension:Collection

I didn't think to search for that. Thanks for catching it. Patch provided to fix