LiquidThreads needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Dec 31 2019, 2:13 AM

Description

See parent task

Details

Subject	Repo	Branch	Lines +/-
Remove use of global $wgUser (part 3)	mediawiki/extensions/LiquidThreads	master	+108 -49
Remove uses of global $wgUser (part 2)	mediawiki/extensions/LiquidThreads	master	+17 -22
Remove uses of global $wgUser (part 1)	mediawiki/extensions/LiquidThreads	master	+48 -55

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved	DannyS712	T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
Resolved	DannyS712	T241619 LiquidThreads needs uses of global $wgUser removed

Event Timeline

DannyS712 created this task.Dec 31 2019, 2:13 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 31 2019, 2:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 561242 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Remove uses of global $wgUser

https://gerrit.wikimedia.org/r/561242

gerritbot added a project: Patch-For-Review.Dec 31 2019, 2:14 AM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Dec 31 2019, 2:31 AM

DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Jan 28 2020, 8:50 PM

DannyS712 added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Feb 23 2020, 10:29 PM

DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.

@Pchelolo can you take a look at the patch for this?

Codesearch: https://codesearch.wmflabs.org/deployed/?q=global%5B%5E%3B%5D%2B%5C%24wgUser%5B%2C%3B%5D&i=nope&files=&repos=mediawiki/extensions/LiquidThreads

Change 561242 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Remove uses of global $wgUser (part 1)

https://gerrit.wikimedia.org/r/561242

Change 576184 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Remove uses of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/576184

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Mar 3 2020, 6:00 AM

Change 576189 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Remove use of global $wgUser (part 3)

https://gerrit.wikimedia.org/r/576189

Change 576184 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Remove uses of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/576184

Change 576189 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Remove use of global $wgUser (part 3)

https://gerrit.wikimedia.org/r/576189

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Mar 3 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2020, 5:10 PM

DannyS712 closed this task as Resolved.Mar 3 2020, 5:30 PM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Mar 4 2020, 7:54 AM

Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 3:00 PM