Page MenuHomePhabricator

Syntaxhighlight: Add tracking category when `enclose` is used
Closed, ResolvedPublic

Description

See [1] - the enclose attribute is deprecated. When set to none, it is silently converted to inline, and otherwise it is simply ignored
I propose that a tracking category be added when the enclose attribute is specified, so that its usage can be tracked and replaced

[1] https://gerrit.wikimedia.org/g/mediawiki/extensions/SyntaxHighlight_GeSHi/+/50c8ad3f1a8d5e134613679df2dc61290acaa9e7/includes/SyntaxHighlight.php#107

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Nirmos added a subscriber: Nirmos.

Adding "easy" on the assumption that this is the one-liner that I think it is. If not, feel free to revert.

Adding "easy" on the assumption that this is the one-liner that I think it is. If not, feel free to revert.

Its 6 lines by my count (add tracking category to extension.json, add name and description to en.json and qqq.json, and actually add the category) and I was planning on completing the task myself...

T137310#4199628 plus T241409#5764055 on top of it, I guess... (those patches are for the EasyTimeline extension though)

Change 562085 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Add a tracking category when the enclose attribute is used

https://gerrit.wikimedia.org/r/562085

Adding "easy" on the assumption that this is the one-liner that I think it is. If not, feel free to revert.

Its 6 lines by my count (add tracking category to extension.json, add name and description to en.json and qqq.json, and actually add the category) and I was planning on completing the task myself...

I made it a bit more complicated by using the same patch for T237267 - both add a tracking category for "deprecated" syntax

Change 562085 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Add tracking categories when deprecated syntax is used

https://gerrit.wikimedia.org/r/562085

Can someone please add the documentation of this to https://www.mediawiki.org/wiki/Extension:SyntaxHighlight and the requisite fix. The fix should be clear and evident. Thanks.

Can someone please add the documentation of this to https://www.mediawiki.org/wiki/Extension:SyntaxHighlight and the requisite fix. The fix should be clear and evident. Thanks.

Done - if it is set to "none", replace it with "inline", otherwise it can just be removed