Geoshapes service is not sending 'access-control-allow-origin' header to some requests
Open, LowPublic
Actions

Assigned To

None

Authored By

	City-busz
	Dec 31 2019, 11:14 AM

Description

Steps to Reproduce

Access https://en.wikivoyage.org/wiki/Talk:Prague#Wikidata_items_for_dynamic_map
Look at the network requests and see that some requests fulfill without a problem and others are canceled due to the lack of access-control-allow-origin header

Expected Results

All requests to maps.wikimedia.org should return access-control-allow-origin header

Actual Results

The presence of access-control-allow-origin header is inconsistent and random

Environments Observed

English Wikivoyage

Additional notes

The ticket was formerly about 429 errors, which is not reproducible at the moment, the history will be preserved for context.

Recently, when I open pages with multi-region maps, the dinamic map fails to load, only the static fallback image is shown. The Kartographer extension tries to load GeoJSON for each regions, but some of them are rejected by the server 'maps.wikimedia.org' with response '429 Too Many Requests'.

It can be easily reproduced on the following pages:
https://en.wikivoyage.org/w/index.php?title=Paris&oldid=3897346#Districts
https://en.wikivoyage.org/w/index.php?title=Vienna&oldid=3897365#Districts
https://en.wikivoyage.org/w/index.php?title=Budapest&oldid=3895843#Districts

Possible solutions are:

Configure the map server to allow more mapshape requests per client at once.

Modify the client JavaScript code to not load mapshapes in parallel, just after each other.

Implement some caching mechanism to reduce the number of requests, and reduce load.

Related discussion:
https://en.wikivoyage.org/wiki/Wikivoyage_talk:Mapmaking_Expedition#Too_Many_Requests_on_loading_complex_dynamic_maps

Related Objects

Mentioned In: T270865: Display map markers on Kartographer maps even in case of mapserver failures

Event Timeline

City-busz created this task.Dec 31 2019, 11:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 31 2019, 11:14 AM

Adding maintainers as per https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_extensions_deployed_on_the_Wikimedia_Cluster (please correct tags AND wiki if outdated)

jcrespo awarded a token.Dec 31 2019, 12:29 PM

LGoto triaged this task as Low priority.Jan 8 2020, 4:46 PM

LGoto removed a project: Product-Infrastructure-Team-Backlog-Deprecated.

Any news? Many of the dynamic maps on Wikivoyage haven't been working for months due to this problem, e.g. https://en.wikivoyage.org/wiki/Paris#Districts

Renek78 updated the task description. (Show Details)May 9 2020, 1:42 PM

@Renek78 I can't replicate the issue. Could you share screenshots or details of the requests?

@MSantos I cannot replicate the issue for Paris, but on the talk page for Prague the map is still not working: https://en.wikivoyage.org/wiki/Talk:Prague#Wikidata_items_for_dynamic_map

Same goes for Vienna (please see link of original poster).

RolandUnger subscribed.Jun 5 2020, 5:18 PM

MSantos added a project: Product-Infrastructure-Team-Backlog-Deprecated.Jul 9 2020, 4:12 PM

MSantos moved this task from Unsorted to Wikivoyage on the Maps (Kartographer) board.

MSantos renamed this task from Too Many Requests on loading complex dynamic maps to Geoshapes service is not sending 'access-control-allow-origin' header to some quests.Jul 9 2020, 5:22 PM

MSantos renamed this task from Geoshapes service is not sending 'access-control-allow-origin' header to some quests to Geoshapes service is not sending 'access-control-allow-origin' header to some requests.

MSantos updated the task description. (Show Details)

MSantos edited projects, added Maps (Kartotherian); removed Maps (Kartographer).

On another note, the requests that are not failing are also missing cache x-cache-status: miss. Adding Traffic to help me understand this information, is it possible that the cache layer is not sending the proper response headers?

Restricted Application added a project: SRE. · View Herald TranscriptJul 14 2020, 2:58 PM

LGoto moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Jul 15 2020, 3:52 PM

MSantos removed MSantos as the assignee of this task.Jul 15 2020, 3:52 PM

MSantos subscribed.

RolandUnger mentioned this in T270865: Display map markers on Kartographer maps even in case of mapserver failures.Dec 28 2020, 9:03 AM

CDanis subscribed.Dec 28 2020, 2:57 PM

The swap of Traffic for Traffic-Icebox in this ticket's set of tags was based on a bulk action for all such tickets that haven't been updated in 6 months or more. This does not imply any human judgement about the validity or importance of the task, and is simply the first step in a larger task cleanup effort. Further manual triage and/or requests for updates will happen this month for all such tickets. For more detail, have a look at the extended explanation on the main page of Traffic-Icebox . Thank you!

We are still seeing this problem. This seems more common on pages with lots of shapes in the map?? And considering this was first about 429 errors, I'm wondering if rate limiting kicks in in some sort of other way perhaps ? Maybe we get 429s on the must-revalidate and we serve up stale data which doesn't have the headers somehow ?

OK, just by refreshing I can just 'fill the cache' and every refresh i have more shapes (with origin control headers), because more shapes have filled the cache. This is absolutely some sort of rate limiting taking place, possibly between the cache and the server.

Also of note, there is no Cache-Control response header, only Age... There is a "Access-Control-Expose-Headers: etag", but no ETag either ? is that a generic setting on the ATS, or was there an ETag before and now no longer ?

Tagging WMDE, as this looks like something that they might be interested in.

BBlack moved this task from Backlog to Complicated on the Traffic-Icebox board.Apr 7 2022, 9:11 PM

	F31814679: image.png
	May 12 2020, 4:46 PM

Geoshapes service is not sending 'access-control-allow-origin' header to some requestsOpen, LowPublicActions