Page MenuHomePhabricator
Create Task
Maniphest T241655

Commons upload warning options are ambiguously worded: "OK" and "Cancel"
Open, Needs TriagePublic
Actions

Description

The following warning:

Warning
We recommend that you properly fill in all the fields. Do you want to continue without correcting these warnings?
It is recommended that you fill in some categories for your uploads.

offers two buttons, "Cancel" and "OK". I don't know which button does what. I think, "OK", means, "Yes, continue", but maybe it means, "OK, let me fill in some categories"? Buttons like this should offer obvious, unambiguous, answers to the question being asked.

Screen Shot 2019-12-31 at 2.41.45 PM.png (2×2 px, 830 KB)

Related Objects

Event Timeline

RoySmith created this task.Dec 31 2019, 7:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 31 2019, 7:43 PM
Reedy added a project: UploadWizard.Dec 31 2019, 7:47 PM
Aklapper renamed this task from Commons upload warning is ambiguously worded to Commons upload warning options are ambiguously worded: "OK" and "Cancel".Dec 31 2019, 8:38 PM
Masumrezarock100 subscribed.EditedDec 31 2019, 9:44 PM

Those looks like a OOUI simple confirmation dialog to me. Those options in simple dialogs can't be customized IIRC. So maybe we need to use other method of constructing OOUI windows.

Ostrzyciel mentioned this in T277293: Upload warning options are ambiguously worded: "OK" and "Cancel".Mar 12 2021, 1:34 PM
Ostrzyciel subscribed.Sep 4 2022, 7:19 PM

FYI: I just fixed this in MediaUploader. The code around the dialog looks the same in UW, so porting the change should be trivial. See: T277293

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL